search

SOFTENG310-Team4 / SMARTJ

SMARTJ is a web application designed to help active job seekers practice their interview skills and find available jobs in their field of study. Developed by Team 4 as part of the SOFTENG 310 course at the University of Auckland.
MIT License
0 stars 11 forks source link

bugfix: Fixed broken navbar button on smaller screens #37

Closed tyin363 closed 3 months ago

tyin363 commented 3 months ago

Context

The navbar toggle button on smaller screens was not functioning as expected, which affected the user experience on mobile devices. This PR addresses the issue by ensuring that the necessary dependencies are correctly included and the toggle functionality works as intended.

Closes #36

What Changed?

Updated the import of Bootstrap and Popper.js in App.js to ensure compatibility and correct functionality. Added jquery import to ensure proper functioning of Bootstrap's JS components. Verified the usage of the correct data attributes in the navbar toggle button and collapse menu.

How To Review

Review the changes in App.js to see the updated imports and ensure the correct scripts are loaded. Check the HTML structure within App.js for the correct use of Bootstrap's data attributes. Test the application on smaller screens to confirm that the navbar toggle button now functions correctly.

Testing

Manually tested the application on various screen sizes to confirm that the navbar menu collapses and expands correctly. Tested the app on both mobile devices and desktop browsers with a resized window.

Risks

Ensure that the imported dependencies do not cause any conflicts with other parts of the application. Double-check that the changes do not affect the layout or functionality on larger screens.

Notes

No additional libraries were added, only the existing ones were correctly utilized. This fix should improve the overall user experience on mobile devices.

syoo881 commented 3 months ago

I really appreciate you doing this bugfix - the navbar menu collapses and expands correctly. There seems to be no critical bugs or issues that need to be addressed. However, I do want to suggest an improvement before merging the PR.

Suggestions

By doing this improvement, I believe the PR will be ready to merge!

tyin363 commented 3 months ago

Thanks for your review Seth! I have made the changes you recommended and I think the nav bar looks much better now.

Let me know if there are any other suggested changes. Otherwise, feel free to approve this PR.

syoo881 commented 3 months ago

Thanks for the changes! Everything looks good to merge :)