SOFTENG310-Team4 / SMARTJ

SMARTJ is a web application designed to help active job seekers practice their interview skills and find available jobs in their field of study. Developed by Team 4 as part of the SOFTENG 310 course at the University of Auckland.
MIT License
0 stars 11 forks source link

Feat/interview settings connection #40

Closed today0-o closed 3 months ago

today0-o commented 3 months ago

Context

This PR addresses the functionality and UX improvements for the InterviewPractice page. Specifically, it ensures that the "Next Question" button behaves as expected by resetting the question and answer components without duplicating them on the page. Additionally, it enforces a limit on the number of questions that can be answered based on the specified numQuestions parameter.

Closes #38

What Changed?

Question and Answer Reset:

How To Review

  1. Review the changes made to InterviewPractice.js for handling the count state and ensuring proper re-renders using the key prop.
  2. Review the TextAnswerComponent.js to verify that the timer and answer reset functionality is correctly implemented.
  3. Check that the QuestionComponent.js is properly reset with a new question upon pressing the "Next Question" button.
  4. Verify that the limit on questions (numQuestions) is enforced, and that the "Finish" button appears when the limit is reached.

Testing

Risks

Notes

tyin363 commented 3 months ago

Good job, Minsung! The PR addresses the key issues with the InterviewPractice page effectively. The reset of answer components, enforcement of the question limit, and button transitions are all handled well. The manual testing seems thorough, and the implementation appears solid. LGTM—ready to merge!