SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
293 stars 142 forks source link

[Cases + Samples]National User can no longer edit multiple sections from cases and samples #10474

Closed adinaflorea9 closed 2 years ago

adinaflorea9 commented 2 years ago

Bug Description

I: A National User is no longer able to edit multiple sections from a case's page:

II: A National User is no longer able to edit multiple fields from a sample's page:

III: A National User is no longer able to see the document that are uploaded to cases.

The behavior is reproducible regardless of whether the entities were created by the National User or another user.

Steps to Reproduce

I and II:

  1. Log in the web app with a National User;
  2. Observe case pages and sample pages.

III: 1 Log in the web app with a National User;

  1. Open a case and from the 'Documents' card, click on the 'New Document' button - 'Start Data Import' and upload any kind of document.

Actual Behavior

I and II: The user is not able to edit multiple sections from case pages and samples pages.

III: The upload is successful, but the documents are not displayed for the National User on the 'Documents' card.

Expected Behavior

I and II: The user should be able to edit the sections mentioned in the 'Bug description'.

III: The documents uploaded successfully should be displayed on the 'Documents' card.

Screenshots

I and II: GIF of the behavior: Fields not editable

III: GIF of the behavior: Documents upload

System Details

Additional Information

The behavior was initially observed during the run of the automated tests.

The behavior is not reproducible on the latest released version 1.75.2.

The behavior was likely introduced by a ticket during the current sprint, but as it could not be determined which exact issue caused it, this current separate ticket was logged.

adinaflorea9 commented 2 years ago

As discussed and tested with @dinua currently the behavior reported in the ticket regarding samples is no longer reproducible on our local machines with the latest version of SORMAS 1.76.0-SNAPSHOT(03765a5). Behavior will be re-tested again in case it becomes reproducible.

To be noted - the National User (default) does not have the user right 'Edit samples reported by other users' so they can only completely edit samples that they reported.

leventegal-she commented 2 years ago

The first point with editing case section is fixed by https://github.com/hzi-braunschweig/SORMAS-Project/issues/10547

Will be merged into development after the hotfix 1.75.4 release

dinua commented 2 years ago

for cases were fixed by @leventegal-she in hotfix 1.75.4 and the rest is no longer reproducible