SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
293 stars 143 forks source link

External message icon is not visible for some samples within a case #11065

Open KristinaBorch opened 1 year ago

KristinaBorch commented 1 year ago

Bug Description

Since the update 1.76.8, several health departments reported that the external message icon is missing for some samples within a case. The problem occurs for older and newer samples. In some cases, the icon is visible for the first sample but not for the second one. Cases with only one sample experiencing the same issue. Next to that, the problem occurs for all user roles and even when adding the external message right later on. Nevertheless, newly processed samples can be viewed.

Steps to Reproduce

The issue cannot be reproduced from our side.

Screenshots

System Details

Expected Behavior

The message icon is visible for all processed external messages.

Additional Information

abrudanancuta commented 1 year ago

Here is the scenario that I found:

  1. The first step will be to create a person
  2. Second step to create a case.
  3. At the 3rd step of the processing the lab message is to add the samples.

@JaquM-HZI and @KristinaBorch waiting for your feedback

SahaLinaPrueger commented 1 year ago

@abrudanancuta What I don't understand is this: The health departments report it concerns old lab messages.

  1. Is it possible that when samples are subsequently added to a lab messages, the book-symbol from the long existing sample in the long existing case is "pulled out" until the new lab message with the additional sample is completely processed?
  2. Is there is a right additionally to the right EXTERNAL_MESSAGE_VIEW that allows a user to see the book-symbol?
  3. Is it possible that the same bug caused #11052 (document delete icon was not visible) cause this?
SahaLinaPrueger commented 1 year ago
  1. Or is it possible that because all lab messages with more than one sample were split up to 1.76, the system is now confused and all messages appear again as "unprocessed" in the lab message directory and must first be processed?
  2. Or, that by the fact that a splitting took place before 1.76, perhaps a second sample was not processed at all or is now considered as not completely processed?

We need an explanation why old samples which had the icon -> now do not have the icon anymore.

kathsievers commented 1 year ago

There is also the issue in Dachau, that users with all neccessary rights are able to see the icon in the samples AFTER the 29th Nov but before the icon disappeared in ALL of the samples. It is highly unlikely that before the update all the lab messages were incompletely managed...

abrudanancuta commented 1 year ago
  1. No
  2. No
  3. No, because the issue about the documents appeared as a consequence of the developing of the ticket #8463, which is in 1.77.0 and the problem with lab message icon appeared in 1.76.8
  4. the new functionality of processing multiple samples from a lab message shouldn't affect the already processed lab messages
  5. I don't see the connection of being split that could affect now the old samples that were processed.

Can we reproduce the problem on test1402? If yes can we have a specific example of a case that has sample without that icon?

SahaLinaPrueger commented 1 year ago

@abrudanancuta you mean to roll-back the 1402 to 1.75.4, process some messages and then update to the 1.76.8 and observe, if the book-symbol is still there?

Because that is the common ground of the health departments: "book-symbol/ external message icon" is not visible anymore for lab messages/samples, which were processed before the update. Lab messages and the associated icon which were processed after the update can be seen.

abrudanancuta commented 1 year ago

If there is the posibility to roll back this env: test1402 , then I would say to do it and as you propose to process some lab messaged and see what happens when putting back the version.

SahaLinaPrueger commented 1 year ago

@abrudanancuta is it possible that the finding of #11107 is an explanation? Maybe some preparation for the lab message shown in the reports was done in the 1.76 ? Nowadays we cannot roll back the 1402 because we test there the 1.77

abrudanancuta commented 1 year ago

The new finding #11107 cannot be connected with this finding. This finding is reported for 1.76.8 and I checked the scenario described in #11107 on the version 1.76.8 which I couldn't reproduce.