SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
294 stars 142 forks source link

Demis messages cannot be downloaded #12040

Closed abrudanancuta closed 1 year ago

abrudanancuta commented 1 year ago

Bug Description

As user when trying to download a message from Demis, from the Messages directory, an error appears and the file is not downloaded

Reproduction Steps

1. 2. ...

Expected Behavior

No response

Affected Area(s)

Web app

SORMAS Version

1.84.0

Android version/Browser

-

User Role(s)

NatUser + Admin

Server URL

https://test1402.sormas.netzlink.com/

Additional Information

DemisDownloadError.txt

abrudanancuta commented 1 year ago

@MartinWahnschaffe had a look about the issue:

sormas-demis-adapter is using jsoup-1.14.2 as compile dependency, which still has the missing function (deprecated though) https://github.com/jhy/jsoup/blob/jsoup-1.14.2/src/main/java/org/jsoup/Jsoup.java#L316 sormas-base is using jsoup-1.15.3 sind 1.84.0 (see #11032) which no longer has the method https://github.com/jhy/jsoup/blob/jsoup-1.15.3/src/main/java/org/jsoup/Jsoup.java#L316

The demis adapter seems to be taking the jsoup version from payara instead of it's own compile dependency.

I'd suggest to change jsoup in sormas-demis-adapter to provided and not overriding the version that is provided in sormas-api which is used in sormas-demis adapter. This of course also means that the deprecated method call has to be replaced.

leventegal-she commented 1 year ago

Closing this because it has nothing to do in SORMAS