SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
292 stars 140 forks source link

Extend the data shown in the duplicate person popup [1] #4003

Closed marko-arn closed 3 years ago

marko-arn commented 3 years ago

TODO: https://github.com/hzi-braunschweig/SORMAS-Project/issues/4003#issuecomment-790177585

Feature Description

If you enter or import a duplicate, a pop-up comes with the data of both persons. This shows for the new person the date of birth only and for the person in Sormas the age:

grafik

It would be better and make the person comparable if either both or only the date of birth would shown for both entries. Only shown the age doesn't help.

bernardsilenou commented 3 years ago

So we only show age if the person is sormas has only age registered.

marko-arn commented 3 years ago

@bernardsilenou I think there are dates entered in the case, as we never enter the age only. But I will check it tomorrow and provide screenshots.

bernardsilenou commented 3 years ago

@Marko-ilmkreis In Germany, we always have birth date but in other countries it is common to have just age only.

marko-arn commented 3 years ago

@bernardsilenou Thats right. I also have customers from other countries and in the past the births were not registered. But as we have entered the dob in any case, in the duplicate pop-up it must shown to compare the cases.

Candice-Louw commented 3 years ago

Further support to include the date of birth, please (from CH).

Additionally, including the Person-ID and telphone number has also been requested as these are likely to be more unique. @Marko-ilmkreis @bernardsilenou - would these make sense to you too, and could they be included in this Issue, or should I create a separate Issue for that for CH servers only?

bernardsilenou commented 3 years ago

@Candice-Louw Excellent point! I think telephone number sound good to add. Since the Person-ID is not often in the data being imported, then I think it may not be helpful to add. These are minor changes, so we can handle all the in this ticket I suppose. If there is no further refinement to make, we can then edit the main issue and summarize the main point

marko-arn commented 3 years ago

@Candice-Louw I agree also with the phone number. As @bernardsilenou written the Person-ID is usually not imported, but in my opinion it could be good to see when the duplicate in the database was created. So the user could see if its maybe a duplicate which was entered the same day by another colleague.

bernardsilenou commented 3 years ago

@Marko-ilmkreis Fro cases, yes we show the date, but for person we do not because the person can stay in the system as long as the law of the country permits. The date that the person was created may not give the information that the user want because: assume a case created was created today, then the person is created today, if after a 3 months or a year and just before the case is deleted the person become a new case (possibly of another disease or the same) or a contact or event part, then when creating the new contact in future, the date of the person would show the date of the initial case. Users who do not understand the whole logic may think it is another person.

marko-arn commented 3 years ago

@bernardsilenou Ok, that make sense not to show for the person itself. Thanks for the explanation!

kwa20 commented 3 years ago

@bernardsilenou Considering the birthdate I also noticed that the system does not allow any discrepancy when the birthdate is provided and does not suggest that there are any duplicates. We should probably allow some variance to account for selection errors.

We could also consider showing the address for comparison, even though I'm not sure how busy the window will become.

bernardsilenou commented 3 years ago

@kwa20 Many people can have the same address and a person can also have many addresses. We can add address but i think this may not increase the sensitivity of the system. If we can find a variable that is unique to a person and is documented most of the time, then we can add. The window is almost full. For adding some variability/ tolerance to birth date or age is also problematic because we want the system to be more conservative ie it should only suggest duplicates to the user when they are true duplicates. It is better to not suggest a duplicate rather than suggesting false duplicate. We can easily merge the same person that was not recorded twice or more as a duplicate, but we cannot "un-merge" retrospectively after a wrong merge was done. One option is to add the address and other variables to the "merge duplicate function" instead

kwa20 commented 3 years ago

@bernardsilenou I thought of the address more of an indicator for the user, not necessarily as a criteria for the system to recognize duplicates. The address might just help users to make a decision. In regards of merging, we do not have a way to merge persons yet, only cases, therefore, it's not as easily resolved if duplicates are not detected. I guess this will eventually be resolved by the persons directory.

Candice-Louw commented 3 years ago

FINAL decision - in both windows during the duplicate person search, the following values should be displayed (in this order, please):

First Name | Last Name | Birthdate (Age) | Gender | Telephone Number | District | Community | City | National Health ID | Passport Number

In DE (https://github.com/hzi-braunschweig/SORMAS-Project/issues/4534) and CH contexts, National Health ID and Passport Number are not used and could be removed from this view, however, these are used in the duplicate detection algorithm and should therefore be displayed here - @MateStrysewske - please give input if this is incorrect?

For Telephone Number, use the first entry (assuming multiple phone numbers will be available soon), or if possible, all that are available.

Clean-up of the values that should be used during the duplicate detection process is a separate issue.

markusmann-vg commented 3 years ago

First Name | Last Name | Nickname | Birthdate (Age) | Present Condition | Gender | Telephone Number | District | Community | City | National Health ID | Passport Number

New column for Telephone Number (primary) will be added.

Prerequisite: #2744

markusmann-vg commented 3 years ago

The data of the found duplicate and the person data should be synched (same colums, same values [like birthdate (age)])

MateStrysewske commented 3 years ago

Additional specifications coming from #4745:

maxiheyner commented 3 years ago

Issue Tracker comment

StefanKock commented 3 years ago

This ticket is not technically mandatory for 1.58.0, but really desired to be included.