SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
291 stars 142 forks source link

Task directory is not accessible to a regional user role #4592

Open bernardsilenou opened 3 years ago

bernardsilenou commented 3 years ago
Performance question from France In one region, the task directory is inaccessible (10min wait then time out) when connected using a regional profile (surveillance supervisor and contact supervisor). This region has more than 3000 active + archived tasks. With an admin or national user profile, the access time is very fast ... a few seconds. Current version is 1.54.1 Will the problem be solved in 1.57 ?
bernardsilenou commented 3 years ago

@carolinverset Is something missing in my description? @MateStrysewske @MartinWahnschaffe @kwa20 can you think of a possible cause? logs would follow soon

kwa20 commented 3 years ago

@bernardsilenou are there any other user roles assigned? I know that the external user produced problems on the task directory since he shouldn't be used for actual users.

bernardsilenou commented 3 years ago

@kwa20 Many other users roles are assigned but I can not tell if they are using external user role. @carolinverset Pls can you verify that external user role is not activated?

carolinverset commented 3 years ago

@carolinverset Is something missing in my description? @MateStrysewske @MartinWahnschaffe @kwa20 can you think of a possible cause? logs would follow soon

No, it's perfect. Except that we are in version 1.52.1 :-) For clarification, other regions with the same profile but a lower number of tasks do not experience this problem. And with the national user profile, access is fast @emond-fuseau @bernardsilenou

carolinverset commented 3 years ago

@bernardsilenou are there any other user roles assigned? I know that the external user produced problems on the task directory since he shouldn't be used for actual users.

@kwa20 Thank you for your comment ! I just checked and this region has assigned the roles of district observer, region observer. Do these profiles=the external user ? Usually in France, we instruct you to give the contact supervisor and surveillance supervisor profile.

@emond-fuseau @bernardsilenou

bernardsilenou commented 3 years ago

@carolinverset These are not external users and your user role looks fine to me. The fact that the region experiencing this issue has many tasks than others signify something that number of task may be related to the issue. The logic that filters the task to show on the ui based on the jurisdiction of the user may be taking long. This may explain whey the national user do not experience this. Waiting for the logs to confirm the cause.

kwa20 commented 3 years ago

@carolinverset @bernardsilenou I'm not quite sure if this is related but I remember that users had long loading time issues before when opening the case directory. I think back then it was caused by cases having many entered visits or other linked entities. Back then I think it was solved by adding indices. Since the task directory has links to several entities, maybe that has an impact.

MateStrysewske commented 3 years ago

I would also suggest to try the indexes that were added with 1.57.0 and see whether they improve the performance. If that's not the case, we need to further investigate these issues.

Candice-Louw commented 3 years ago

@MateStrysewske @carolinverset @bernardsilenou

Similar error reported on test.sormas.ch test system (blocking rollout to productive systems to 1.56.1 in CH):

image

@MateStrysewske - I believe you have access to this system, so you may be able to reproduce this by adding either "National User or National Clinician or National Observer" to your role, then opening the Tasks tab.

StefanKock commented 3 years ago

@Candice-Louw our team does not have access to the system, but for that error message we need to have the stack trace to find out what's wrong. I think the problem is not related to the long running process @bernardsilenou reported at ticket start.

Candice-Louw commented 3 years ago

@StefanKock - thank you. Agreed. I will reproduce the error on this CH test system, request the stack trace from Netzlink and post back here once received.

StefanKock commented 3 years ago

@StefanKock - thank you. Agreed. I will reproduce the error on this CH test system, request the stack trace from Netzlink and post back here once received.

Please on a new ticket, thanks.

carolinverset commented 3 years ago

@carolinverset These are not external users and your user role looks fine to me. The fact that the region experiencing this issue has many tasks than others signify something that number of task may be related to the issue. The logic that filters the task to show on the ui based on the jurisdiction of the user may be taking long. This may explain whey the national user do not experience this. Waiting for the logs to confirm the cause.

@bernardsilenou @kwa20 @emond-fuseau Here are the logs that our integrator sent us. Does this match the demand? thank you for everything and have a nice day

sormas.log

bernardsilenou commented 3 years ago

@StefanKock @MateStrysewske Any suggestion on how we can go on with this? Regional user accounts in a region in France are completely blocked, Can you confirm that 1.57 or 1.58 would resolve this challenge? Thanks

MateStrysewske commented 3 years ago

@carolinverset The error logs that you attached seem more related to an error when trying to save a task because the value entered in one of the fields is too large. Shouldn't have anything to do with the task directory.

@bernardsilenou 1.57 adds a lot of indexes. Those could definitely improve the performance. I can't say that for sure though because I currently have no way to test and verify this. It's definitely worth a shot.

bernardsilenou commented 3 years ago

@MateStrysewske Thanks for the infos. @CarolinVerset We just need to upgrade and see how it goes.