Closed JaquM-HZI closed 3 years ago
https://github.com/hzi-braunschweig/SORMAS-Project/issues/4116 I linked the official RKI document there as well I think
Issue Tracker Comment
The comment from @maxiheyner is covered by a new issue https://github.com/hzi-braunschweig/SORMAS-Project/issues/5324 and is NOT part of this one!
@JaquM Please add to the prio_list and priritize
@JaquM I've updated the development specifications based on the currently disabled case classification validation logic for German systems. I guess the clinical picture part is not up-to-date. Can you please update the clinical picture for Covid-19 based on the exact symptoms that we have in the system?
@MateStrysewske I've updated the exact symptoms Everything else is up-to-date.
@JaquM Thanks! Can you check whether the development specifications I have added to the initial issue are correct and complete? Not sure whether the "clinical picture not fulfilled" part means that ONLY the symptoms of the clinical picture should be set to false/unknown/null (sounds like it) or whether ALL symptoms possibly related to Covid-19 should be false/unknown/null (like it's implemented in the unused validation right now)?
@MateStrysewske @JaquM The 'clinical picture not fulfilled' part looks good to me. However, I noticed some inconsistencies which we should refine:
epidemiologicalConfirmation
= YES and/or a link to an event of eventStatus
= CLUSTER@kwa20 The automatic case classification during save can be disabled on German systems (probably is already). If it's enabled and the user has overwritten the classification manually, the automatic classification will never overwrite it with a lower value again (only with a higher one). I think NO_CASE overwrites everything in that logic already.
I just tested this issue on the nightly build server and found the following things:
classifications 'confirmed - no symptoms' and 'confirmed - unknown symptoms' do not get properly calculated either automatically nor via manual trigger.
I also couldn't find many of the strings in the info pop-up available on crowdin. @sergiupacurariu Do you think we could add them so I can adjust some translations there, please?
I further noticed that the calculation now contradicts the setting of confirmed cases when entering a positive test result. When a user enters a positive test result for a case, they're asked if they want to confirm the case. The case is then set to confirmed, even if entered data in symptoms should classify them as either 'confirmed - no symptoms' or 'confirmed - unknown symptoms'. I'm not sure if this could be handled with this calculation or if this needs to be an issue purely related to the other pop-up in samples. Please let me know :)
Found by @syntakker : Minor finding: Automated recalculation for case classification is not triggered when a cluster event is unlinked (for classification "suspect" + cluster event => "probable", unlink cluster event =>"suspect")
When a cluster event is unlinked from a case, the case is not saved. The automatic calculation is triggered only if the case is saved. In case the event is unlinked the user could use the "Calculate case classification" button to manually trigger the calculation.
@sergiupacurariu we please need to add "sore throat / pharyngitis" as symptom for the clinical picture. I'm sorry for this last minute change.
@JaquM In the classification rules we have two sets of symptoms:
@sergiupacurariu the first set please
Verified on Local and https://test-de.sormas.netzlink.com/, Version: 1.61.0-SNAPSHOT
Further informations in https://github.com/hzi-braunschweig/SORMAS-Project/issues/4770#issuecomment-832503288
Situation Description
For Germany only, the case classification should be calculated according to the RKI standards, when clicking a button "calculate" which is next to the case classification
The calculation must be based on the information available in each case. Belongs to #3004
Feature Description
*Clinical picture: at least one of the following symptoms:
Possible Alternatives
Additional Information
@kwa20
To do: => Remove validation => Add "calculate" option => In Germany automatic caseclassification = false
Development Specifications
ClassificationAllSymptomsCriteriaDto
which is passed the SymptomsDto and a SymptomState and goes through all symptoms where the@Diseases
annotation contains the disease in question and checks whether the value matches the given SymptomState; the eval method returns true if all symptoms match the SymptomState and false if at least one symptom does not match the SymptomState; should also be possible to call this criteria with null in which case it verifies that all symptoms have no valuepneumoniaClinicalOrRadiologic
,difficultyBreathing
,cough
,runnyNose
,respiratoryDiseaseVentilation
,acuteRespiratoryDistressSyndrome
,lossOfTaste
,lossOfSmell
PCR_RT_PCR
,ANTIGEN_DETECTION
,ISOLATION
orSEQUENZING
fever
,generalSignsOfDisease
,diarrhea
,fastHeartRate
,rapidBreathing
,oxygenSaturationLower94
,vomiting
,chillsSweats