SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
291 stars 142 forks source link

Quarantine end automatically set after importing contact person cat.II #4940

Open maxiheyner opened 3 years ago

maxiheyner commented 3 years ago

Bug Description

This bug concerns the import of contact persons of category II with intended missing quarantine information. Currently one can only import a contact person of category II without quarantine information, when its relationship with case was set to "other family member or friend". The failure occurs when the type of contact was set to "was in the same room or house with source case", then SORMAS automatically adds a quarantine end date (10 days after last contact), but no start date, although no quarantine related dates were actively imported by the user.

Steps to Reproduce

  1. perform an import of several contact persons of category II (contactCategory = LOW_RISK) no quarantine dates are given
  2. After importing contact persons of category II with a SAME_ROOM contact quarantine end dates are automatically prefilled, and timed for 10 days after last contact, although no quarantine end date was actively added by the user. [3. After importing contact persons of category II with a FACE_TO_FACE_SHORT contact (family members/friends) quarantine dates are not automatically set)]

Expected Behavior

No automated inclusion of quarantine dates after importing contacts, but only by intention. Adapt existing parameters for FACE_TO_FACE_SHORT (no quarantine, no follow up)contact category to SAME-ROOM, too.

Screenshots

contact categories of 6 contact persons: image contact SAME_ROOM leads to an automated quarantine end date calculation (10 days after last contact): image Off note: FACE_TO_FACE_SHORT (family members/friends --> no follow-up SAME_ROOM --> follow-up for 10 days following last contact situation image

System Details

Additional Information

MateStrysewske commented 3 years ago

@maxiheyner If I'm not totally mistaken, based on your screenshots, this is not about quarantine end dates, but about follow-up end dates, and it's expected behaviour that those are automatically set. The reason why they're not set for low risk contacts is that follow-up is automatically disabled for those.

Can you please check whether there are actually automatic quarantine end dates generated?

maxiheyner commented 3 years ago

@MateStrysewske This exactly is about the quarantine end dates. When a contact of cat.II (SAME_ROOM) is imported automatically quarantine end date is set (see screenshot 2), accompanied by follow-up..., both is not intended, since no data was imported. And both mentioned contacts of cat II are low risk (SAME_ROOM and FACE_TO_FACE_SHORT).

MateStrysewske commented 3 years ago

@maxiheyner It actually is intended. The follow-up date is automatically calculated because that's a core functionality of SORMAS, and it's based on the follow-up period of the respective disease. The only exception (in Germany) are contacts with a contact proximity that has follow-up disabled by default (so not all low risk contacts - SAME_ROOM has follow-up enabled, FACE_TO_FACE_SHORT doesn't).

The quarantine end date then is automatically adjusted to match the follow-up end date - that functionality was specifically requested for Germany.

If there are parts of this logic that need to be changed, I can change this issue to a change request, but I would then request confirmation by @kwa20 and @JaquM.

JaquM-HZI commented 3 years ago

This will maybe be solved with having the #6862 @MateStrysewske we should be able to reach the mentioned change via import as well. What do you think? @kwa20 @maxiheyner fyi