search

SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
293 stars 142 forks source link

Make fields in previous hospitalizations non-compulsory by adding an option "unknown" [2] #5748

Closed kwa20 closed 3 years ago

kwa20 commented 3 years ago

Feature Description

Currently, region, district and hospital are compulsory fields in previous hospitalizations. This causes some problems when initially importing data from SurvNet when regional information are missing in the import file.

previousHospitalizationsCompulsory

Problem Description

If data is imported through the converter that does not lead to these fields being filled, detailed exports can not be done properly because these fields include corrupt data.

Proposed Change

Make these fields non-compulsory. This should usually not be affected by transferring cases because the place of stay location is still compulsory.

Possible Alternatives

Somehow introduce always available values like UNKNOWN for infrastructure data so fields can be set if this information is missing in import files.

Additional Information

https://github.com/hzi-braunschweig/sormas-survnet-interface/issues/162

vidi42 commented 3 years ago

@kwa20 in your proposed change, are you suggesting to make them optional as a generic change, or just when the entities originate from the SurvNet converter import?

kwa20 commented 3 years ago

@vidi42 I would suggest to make them optional in general as seen in for example addresses in persons.

MateStrysewske commented 3 years ago

I don't really agree with this change request. The hospital is a compulsory field because a previous hospitalization without an associated hospital would not be very helpful. The region and district are compulsory subsequently because they are needed in order to filter for the hospital. If this is a problem for SurvNet, it should be taken care of in the converter, but we shouldn't provoke reduced data quality in SORMAS just because of that.

markusmann-vg commented 3 years ago

@MateStrysewske If it's a previous hospitalization we keep the fields (Region, District, hospital) mandatory but we add the "unknown" to the enum with the value "NULL" which can be selected. If this is an approach for "de-servers" only , do we need it for the mobile app?

MateStrysewske commented 3 years ago

@kwa20 Does SurvNet contain previous hospitalizations without any facility information? Or is it just the region and district that are missing?

kwa20 commented 3 years ago

@MateStrysewske In SurvNet, hospitalizations are not split into current and previous and any hospitalizations can indeed have missing information for either location or facility.

MateStrysewske commented 3 years ago

@Chinedar I'd like to have your opinion on this. Would making all fields of previous hospitalizations optional have a negative impact on data quality?

Chinedar commented 3 years ago

No, I think it's fine if it's optional with the "unknown" option added as well.

On Thu, 24 Jun 2021, 07:44 Maté Strysewske, @.***> wrote:

@Chinedar https://github.com/Chinedar I'd like to have your opinion on this. Would making all fields of previous hospitalizations optional have a negative impact on data quality?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hzi-braunschweig/SORMAS-Project/issues/5748#issuecomment-867384198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPKP5DACXOIMYANPDLCAN3TULH53ANCNFSM46NWYSSA .