SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
293 stars 143 forks source link

Admin, National Clinician - Port Health Tab missing - The tab is missing when admin creates a case with origin as point of entry #9360

Closed abrudanancuta closed 1 year ago

abrudanancuta commented 2 years ago

Bug Description

The tab Port Health is missing when Admin, National Clinician creates a Case with origin as point of entry

Steps to Reproduce

  1. As user having the assigned role only Admin or National Clinician, create a Case with origin: Point of entry
  2. Complete only the mandatory fields
  3. Save the new Case
  4. Look for the Port Health tab

Actual Behavior

Admin cannot see the Port health tab in the Case edit form

Expected Behavior

Admin, National Clinician has the right to View and Edit Port health and should be able to see the Port Health tab in the Case edit form PORT_HEALTH_INFO_VIEW = Yes PORT_HEALTH_INFO_EDIT = Yes

Screenshots

System Details

Additional Information

roxanamlendea commented 2 years ago

This is also reproducible in the following scenario:

  1. Log in with a Region Observer;
  2. Navigate to the Cases Directory and select 'Point of Entry' in the 'Case Origin' filter;
  3. Open one of the resulting Cases and inspect the tabs;
abrudanancuta commented 2 years ago

Port Health is also not visible for National Observer. If the case has the origin as Point of entry, then the Port Health tab is missing

dinua commented 1 year ago

@MateStrysewske In order to see that menu tab the case pointOfEntry should have a value (different from null) . When this user try to access the case directory , the Pseudonymized set case.pointOfEntry to null . I do not know exactly where the problem is here ? if the tab should require that not null condition or if the Pseudonymized should not set set that value to null.

MateStrysewske commented 1 year ago

@dinua I guess that means that in order to determine whether the tab shows up or not, IF the value in the pointOfEntry field is null, we have to do an additional database query to check whether this is a port health case or not. If the pointOfEntry field is filled in the first place, we of course don't need that query. Whether or not the tab shows up or not should then depend on the result of these two operations.

StefanKock commented 1 year ago

Too many open questions concerning pseudonymisation, cannot be fixed today for 1.78.0

adinaflorea9 commented 1 year ago

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.79.0-SNAPSHOT(36dfdcd).