SORMAS-Foundation / SORMAS-Project

SORMAS (Surveillance, Outbreak Response Management and Analysis System) is an early warning and management system to fight the spread of infectious diseases.
https://sormas.org
GNU General Public License v3.0
293 stars 143 forks source link

Move functional information from toString to getCaption methods II [5] #9759

Closed StefanKock closed 1 year ago

StefanKock commented 2 years ago

Problem Description

Follow-up to #8314: Not all DTOs were covered.

Proposed Change

Acceptance Criteria

Implementation Details

List of (super-) classes that need to be changed:

  1. ReferenceDto
  2. In the android-app all subclasses of AbstractDomainObject need to be checked (for example Person).

Idea: Introduce Interface HasCaption for formatting EntityDto and ReferenceDto classes to ease the use of CaptionRenderer.

Additional Information

StefanKock commented 1 year ago

Decided in the Planning this ticket might accidently break anywhere in the UIs, so we will move it to 1.79: Merge early and do a lot of UI reviews.

leventegal-she commented 1 year ago

Reponening because the component columns are not rendered correctly image

adinaflorea9 commented 1 year ago

I think that the user roles might have been affected by this ticket as well, as their user role names that we had predefined before (such as National User, Admin, etc) are no longer visible but instead we have some uuids: image

adinaflorea9 commented 1 year ago

Observed with @abrudanancuta that the Shares directory was affected as well: image

abrudanancuta commented 1 year ago

The problem for directories Shares and Messages was fixed

abrudanancuta commented 1 year ago

The same problem appears for Configuration directory, for the tabs:

The same problem for directories:

adinaflorea9 commented 1 year ago

Additional:

adinaflorea9 commented 1 year ago

Later edit - the same happens for community as well, in the same place mentioned in comment https://github.com/hzi-braunschweig/SORMAS-Project/issues/9759#issuecomment-1383761614

abrudanancuta commented 1 year ago

At detailed export file for Case, Contact the column Reporting UserRole is malformed. sormas_kontakte2023-01-18.csv sormas_fälle2023-01-18.csv

I will reopen the ticket

abrudanancuta commented 1 year ago

Validated on test.sormas with the version: 1.79.0-SNAPSHOT (ef8ee0a)