SPAAM-community / AncientMetagenomeDir

Repository containing lists of all published ancient metagenomic (and related) samples and libraries
http://www.spaam-community.org/AncientMetagenomeDir/
Creative Commons Attribution 4.0 International
64 stars 30 forks source link

Merge Jackson2024 #1161

Closed iseultj closed 4 months ago

iseultj commented 4 months ago

Before merging - should I also add to single genome host assoc.? Raw reads & aligned bams available for T. forsythia and S. mutans (and bams aligned to T. denticola, but this is basically unusable in downstream analysis as is).

Pull Request

This PR is for a

For the following list(s):

This is to close #1160

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

iseultj commented 4 months ago

@spaam-bot please autofill ancientsinglegenome-hostassociated_libraries.tsv Jackson2024

iseultj commented 4 months ago

@spaam-bot please autofill ancientsinglegenome-hostassociated_libraries.tsv Jackson2024

jfy133 commented 4 months ago

@iseultj it needs to be the table name without _libraries.tsv suffix, I realise now the terminology is unclear now πŸ˜…

iseultj commented 4 months ago

@iseultj it needs to be the table name without _libraries.tsv suffix, I realise now the terminology is unclear now πŸ˜…

Oh cool! that makes sense πŸ˜„ could you merge the other PR I made (#1162) so Streptococcus mutans is an allowed species? Thanks!

jfy133 commented 4 months ago

@iseultj it needs to be the table name without _libraries.tsv suffix, I realise now the terminology is unclear now πŸ˜…

Oh cool! that makes sense πŸ˜„ could you merge the other PR I made (#1162) so Streptococcus mutans is an allowed species? Thanks!

I approved it, do you not have merge permissions?

iseultj commented 4 months ago

@iseultj it needs to be the table name without _libraries.tsv suffix, I realise now the terminology is unclear now πŸ˜…

Oh cool! that makes sense πŸ˜„ could you merge the other PR I made (#1162) so Streptococcus mutans is an allowed species? Thanks!

I approved it, do you not have merge permissions?

No, sorry!

jfy133 commented 4 months ago

Oh! Ok! Merged for you!@

iseultj commented 4 months ago

@spaam-bot please autofill ancientsinglegenome-hostassociated Jackson2024

iseultj commented 4 months ago

All done - I think it might be better to get the ftp link for the submitted file rather than the file generated by the ENA/SRA though (which is what it does currently)- I have put ftp links and md5sums for the submitted files, because with the aligned bam, you get a generated fastq and have to realign anyway (which I assume people would prefer to go to the raw data for anyway). If you prefer the generated file, let me know and I'll modify it again :)

jfy133 commented 4 months ago

@spaam-bot please autofill ancientsinglegenome-hostassociated Jackson2024

jfy133 commented 4 months ago

@spaam-bot please autofill ancientmetagenome-hostassociated Jackson2024

iseultj commented 4 months ago

@spaam-bot please autofill ancientmetagenome-hostassociated Jackson2024

iseultj commented 4 months ago

@jfy133 I've made most of those changes - I don't think it really makes sense to treat them as one sample, given that when analysed there are 2 different genomes from each tooth, and if people want to include them in metagenomic analysis, each subsample of the tooth is pretty different. If you're ok with that, I think this is ready to merge - I have updated the dates and ftp links, and the automatically generated table is working well :)

github-actions[bot] commented 4 months ago

AMDirT, version 1.5.0

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid