Closed ktozdogan closed 1 year ago
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json
Errors were found, please unfold below to see errors:
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json
Errors were found, please unfold below to see errors:
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json All is good, no errors were found !
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json All is good, no errors were found !
@jfy133
Working on the library information now!
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I am going to have a look at other publications, but 'terrestrial' sounds good actually.
guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
Oh wow... that's a bit pants. Ok fair enough... it won't be very 'findable' I guess, but it is what it is...
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json
Errors were found, please unfold below to see errors:
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json
Errors were found, please unfold below to see errors:
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json
Errors were found, please unfold below to see errors:
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json
Errors were found, please unfold below to see errors:
* The site isn't really archaeological I think. Probably something like 'terrestrial' or something like would suffice (check other publications here, and try exploring ENVO: https://www.ebi.ac.uk/ols/).
I couldn't find a term that would fit entirely there, the closest would be "terrigenous". Adding "slump" would be too specific, right? I think "terrestrial" is good, adding it to the list would be nice for these kinds of samples.
* The site isn't really archaeological I think. Probably something like 'terrestrial' or something like would suffice (check other publications here, and try exploring ENVO: https://www.ebi.ac.uk/ols/).
I couldn't find a term that would fit entirely there, the closest would be "terrigenous". Adding "slump" would be too specific, right? I think "terrestrial" is good, adding it to the list would be nice for these kinds of samples.
What about thermokarst: https://www.ebi.ac.uk/ols/ontologies/envo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FENVO_03000085
* The site isn't really archaeological I think. Probably something like 'terrestrial' or something like would suffice (check other publications here, and try exploring ENVO: https://www.ebi.ac.uk/ols/).
I couldn't find a term that would fit entirely there, the closest would be "terrigenous". Adding "slump" would be too specific, right? I think "terrestrial" is good, adding it to the list would be nice for these kinds of samples.
What about thermokarst: https://www.ebi.ac.uk/ols/ontologies/envo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FENVO_03000085
I think if it is not too specific in terms of keeping the terms more general, I would say we should go for it.
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I can't actually find this table in their publication?! Which one is it?
* The site isn't really archaeological I think. Probably something like 'terrestrial' or something like would suffice (check other publications here, and try exploring ENVO: https://www.ebi.ac.uk/ols/).
I couldn't find a term that would fit entirely there, the closest would be "terrigenous". Adding "slump" would be too specific, right? I think "terrestrial" is good, adding it to the list would be nice for these kinds of samples.
What about thermokarst: https://www.ebi.ac.uk/ols/ontologies/envo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FENVO_03000085 https://en.wikipedia.org/wiki/Batagaika_crater
I think if it is not too specific in terms of keeping the terms more general, I would say we should go for it.
No, in this case I think it's alright. I'm not so fussy about this particular column ;)
Note: to add thermokarst
you will need to make a fresh branch off of master
, update the corresponding assets/enum
, and open the PR
Then once that is merged, you can update this PR here with the correct term :)
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I can't actually find this table in their publication?! Which one is it?
It is the edn3336-sup-0006-TableS3.xlsx file. And the tab is called "Shotgun_sequencing_statistics".
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I can't actually find this table in their publication?! Which one is it?
It is the edn3336-sup-0006-TableS3.xlsx file. And the tab is called "Shotgun_sequencing_statistics".
Except these are not sequence as in core-sequence but literally the 'DNA sequencing' IDs, so B17 and B17- is the core-sequence samples they have derived from, and `APMG-` will be the library IDs. S oyou will need to update the sample table
You can see this because the extraction blanks also have a Seq_ID withh an APMG code
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I can't actually find this table in their publication?! Which one is it?
It is the edn3336-sup-0006-TableS3.xlsx file. And the tab is called "Shotgun_sequencing_statistics".
Except these are not sequence as in core-sequence but literally the 'DNA sequencing' IDs, so B17 and B17- is the core-sequence samples they have derived from, and `APMG-` will be the library IDs. S oyou will need to update the sample table
You can see this because the extraction blanks also have a Seq_ID withh an APMG code
Oh okay, now I see. So the sequence_name should be the core ID, the sample name is the individual ID for the sample derived from the core ID, and the library ID would be the sequence ID, APMG in this case? If yes, I got the sequence_name all wrong then. I thought it was the library ID. I will update them. Sorry about that. :)
APMG IDs are the ones they assigned for the libraries. I guess they mention them first time on the supplementary table about the shotgun sequencing and used those IDs on ENA as well (eg 210810_A00902_A_L1-2_APMG-36-3_R1.fastq.gz).
I can't actually find this table in their publication?! Which one is it?
It is the edn3336-sup-0006-TableS3.xlsx file. And the tab is called "Shotgun_sequencing_statistics".
Except these are not sequence as in core-sequence but literally the 'DNA sequencing' IDs, so B17 and B17- is the core-sequence samples they have derived from, and `APMG-` will be the library IDs. S oyou will need to update the sample table
You can see this because the extraction blanks also have a Seq_ID withh an APMG code
Oh okay, now I see. So the sequence_name should be the core ID, the sample name is the individual ID for the sample derived from the core ID, and the library ID would be the sequence ID, APMG in this case? If yes, I got the sequence_name all wrong then. I thought it was the library ID. I will update them. Sorry about that. :)
Yes exactly! Sorry that wasn't clear. We don't point to any 'DNA' level stuff in the sample table
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json All is good, no errors were found !
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json All is good, no errors were found !
ancientMetagenomeDirCheck, version 1.3
Checking ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s.tsv against schema ancientmetagenome-hostassociated/samples/ancientmetagenome-hostassociated_sample s_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples.tsv against schema ancientsinglegenome-hostassociated/samples/ancientsinglegenome-hostassociated_sa mples_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/samples/ancientmetagenome-environmental_samples. tsv against schema ancientmetagenome-environmental/samples/ancientmetagenome-environmentalsamples schema.json All is good, no errors were found !
Checking ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries.tsv against schema ancientmetagenome-hostassociated/libraries/ancientmetagenome-hostassociated_libr aries_schema.json All is good, no errors were found !
Checking ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries.tsv against schema ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated libraries_schema.json All is good, no errors were found !
Checking ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies.tsv against schema ancientmetagenome-environmental/libraries/ancientmetagenome-environmental_librar ies_schema.json All is good, no errors were found !
Pull Request
This PR is for a
For the following list(s):
New Publication
Publication Information
This pull request is to add samples from the following publication(s): Courtin et al., 2022 10.1002/edn3.336
This is to close #932
Checklist
github-bot
)?/assets/enums
, e.g. material or archive)? If so the corresponding PR is here:If you do not know how to check errors in failed validation checks, expand here
Correction
This PR is for
Reference
This pull request is to correct samples from the following publication(s):
This is to close
Description
The issue is:
Checklist
github-bot
)?