SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
412 stars 229 forks source link

flags.guess sets -Werror for gfortran which causes the compilation of src/specfem3D/fault_solver_dynamic.f90 to fail #1167

Closed epcc-mjf closed 6 years ago

epcc-mjf commented 6 years ago

flags.guess sets -Werror for gfortran compilations, which means that the compilation of src/specfem3D/fault_solver_dynamic.f90 fails:

mjf@eslogin006:~/test/Q935456/specfem3d> git log -n 1 | cat commit b0aebc68136451f5bb0a92f199727185d02343ca Merge: 198b1c7 072b3a9 Author: Dimitri Komatitsch komatits@users.noreply.github.com Date: Fri Nov 3 23:28:05 2017 +0100

Merge pull request #1162 from komatits/devel

put three of the four examples back because they were not broken

mjf@eslogin006:~/test/Q935456/specfem3d> gfortran --version GNU Fortran (GCC) 6.3.0 20161221 (Cray Inc.) Copyright (C) 2016 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

mjf@eslogin006:~/test/Q935456/specfem3d> gfortran -g -O2 -std=f2003 -fimplicit-none -frange-check -fmax-errors=10 -pedantic -pedantic-errors -Waliasing -Wampersand -Wcharacter-truncation -Wline-truncation -Wsurprising -Wno-tabs -Wunderflow -ffpe-trap=invalid,zero,overflow -Wunused -Werror -O3 -finline-functions -J./obj -I./obj -I. -I./setup -c -o obj/fault_solver_dynamic.spec.o src/specfem3D/fault_solver_dynamic.f90 src/specfem3D/fault_solver_dynamic.f90:408:0:

 subroutine load_stress_tpv35   !added by kangchen this is specially made for Balochistan Simulation

Error: 'load_stress_tpv35' defined but not used [-Werror=unused-function] f951: all warnings being treated as errors mjf@eslogin006:~/test/Q935456/specfem3d>

komatits commented 6 years ago

Thank you very much. You are right, that routine was unused. I have commented it out, the problem will be fixed in GitHub in a few minutes.

Some versions of gfortran detect unused routines, others do not, it seems that the one we use for BuildBot (our test and validation Bot) does not.

Thanks, Cheers, Dimitri.

On 11/16/2017 10:51 AM, epcc-mjf wrote:

flags.guess sets -Werror for gfortran compilations, which means that the compilation of src/specfem3D/fault_solver_dynamic.f90 fails:

mjf@eslogin006:~/test/Q935456/specfem3d> git log -n 1 | cat commit b0aebc6 https://github.com/geodynamics/specfem3d/commit/b0aebc68136451f5bb0a92f199727185d02343ca Merge: 198b1c7 https://github.com/geodynamics/specfem3d/commit/198b1c7eb7aba36a215d971e945205d0680fb2a6 072b3a9 https://github.com/geodynamics/specfem3d/commit/072b3a9c38da3c6dfa2d9f3ca16181b56b4dfac8 Author: Dimitri Komatitsch komatits@users.noreply.github.com mailto:komatits@users.noreply.github.com Date: Fri Nov 3 23:28:05 2017 +0100

|Merge pull request #1162 from komatits/devel put three of the four examples back because they were not broken |

mjf@eslogin006:~/test/Q935456/specfem3d> gfortran --version GNU Fortran (GCC) 6.3.0 20161221 (Cray Inc.) Copyright (C) 2016 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

mjf@eslogin006:~/test/Q935456/specfem3d> gfortran -g -O2 -std=f2003 -fimplicit-none -frange-check -fmax-errors=10 -pedantic -pedantic-errors -Waliasing -Wampersand -Wcharacter-truncation -Wline-truncation -Wsurprising -Wno-tabs -Wunderflow -ffpe-trap=invalid,zero,overflow -Wunused -Werror -O3 -finline-functions -J./obj -I./obj -I. -I./setup -c -o obj/fault_solver_dynamic.spec.o src/specfem3D/fault_solver_dynamic.f90 src/specfem3D/fault_solver_dynamic.f90:408:0:

|subroutine load_stress_tpv35 !added by kangchen this is specially made for Balochistan Simulation |

Error: 'load_stress_tpv35' defined but not used [-Werror=unused-function] f951: all warnings being treated as errors mjf@eslogin006:~/test/Q935456/specfem3d>

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/geodynamics/specfem3d/issues/1167, or mute the thread https://github.com/notifications/unsubscribe-auth/AFjDKQ-ola2-DEVw7T-hNpv0qgq68vRMks5s3AWsgaJpZM4QgOKv.

-- Dimitri Komatitsch, CNRS Research Director (DR CNRS) Laboratory of Mechanics and Acoustics, Marseille, France http://komatitsch.free.fr

epcc-mjf commented 6 years ago

Thanks Dimitri,

Mark

-----Original Message----- Thank you very much. You are right, that routine was unused. I have commented it out, the problem will be fixed in GitHub in a few minutes.

Some versions of gfortran detect unused routines, others do not, it seems that the one we use for BuildBot (our test and validation Bot) does not.

-- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.