buildbot-princeton
commented
2 years ago Your changes passed the buildbot test. See build 915.
Closed Huihuiweng closed 2 years ago
buildbot-princeton
commented
2 years ago Your changes passed the buildbot test. See build 915.
danielpeter
commented
2 years ago thanks for resubmitting! will accept it shortly after the tests have passed...
for future PRs, please avoid all these explicit "Merge branch devel .." commits by using a git rebase .. command. for example, to rebase to the current devel branch of your upstream/devel version:
git fetch upstream
git rebase --interactive upstream/develotherwise, the commit history here will fill up quickly with all these Merge-commits.
codecov-commenter
commented
2 years ago Merging #1471 (844d70a) into devel (16ba2f4) will increase coverage by
46.71%. The diff coverage is80.00%.
@@ Coverage Diff @@
## devel #1471 +/- ##
==========================================
+ Coverage 0 46.71% +46.71%
==========================================
Files 0 249 +249
Lines 0 54108 +54108
==========================================
+ Hits 0 25278 +25278
- Misses 0 28830 +28830 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/specfem3D/fault_solver_dynamic.f90 | 46.13% <80.00%> (ø) |
|
| src/shared/force_ftz.c | 100.00% <0.00%> (ø) |
|
| src/specfem3D/surface_or_volume_integral.f90 | 0.00% <0.00%> (ø) |
|
| src/specfem3D/locate_source.F90 | 90.03% <0.00%> (ø) |
|
| ...or_model/inversion_scheme/inversion_scheme_mod.f90 | 0.00% <0.00%> (ø) |
|
| src/specfem3D/compute_element_att_memory.f90 | 100.00% <0.00%> (ø) |
|
| src/shared/read_value_parameters.f90 | 65.15% <0.00%> (ø) |
|
| ...m_for_model/inversion_scheme/fwi_iteration_mod.f90 | 0.00% <0.00%> (ø) |
|
| .../inverse_problem_for_model/inverse_problem_par.f90 | 0.00% <0.00%> (ø) |
|
| src/specfem3D/prepare_gpu.f90 | 0.00% <0.00%> (ø) |
|
| ... and 240 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 16ba2f4...844d70a. Read the comment docs.
Huihuiweng
commented
2 years ago thanks for resubmitting! will accept it shortly after the tests have passed...
for future PRs, please avoid all these explicit "Merge branch devel .." commits by using a
git rebase ..command. for example, to rebase to the current devel branch of your upstream/devel version:git fetch upstream git rebase --interactive upstream/develotherwise, the commit history here will fill up quickly with all these Merge-commits.
Thanks a lot for the reminder.
I am a new learner of git. Is it possible to merge all my commits into a single one before the pull request?
danielpeter
commented
2 years ago yes, merging commits is also possible with the git rebase --interactive .. command. it will allow you in the edit dialog to squash a commit into a previous one by setting s .. in front of the commit instead of pick ...
danielpeter
commented
2 years ago accept
On 18 Nov 2021, at 4:36 PM, buildbot-princeton @.**@.>> wrote:
Your changes passed the buildbot test. See build 915https://urldefense.com/v3/__http://specfem3d-buildbot.princeton.edu/builders/specfem3d_builder/builds/915__;!!Nmw4Hv0!nk3rB0Z_91YAKpSNcuYIGQiet8kixhFFs_iBX_dOswnIaN871gAIwtvVDvzKlhi3NoVC_w$.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/geodynamics/specfem3d/pull/1471*issuecomment-972871891__;Iw!!Nmw4Hv0!nk3rB0Z_91YAKpSNcuYIGQiet8kixhFFs_iBX_dOswnIaN871gAIwtvVDvzKlhhzj3FwvA$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABMLXWLYNXSIPA6VSF6BOOTUMT6NBANCNFSM5IJSXLKQ__;!!Nmw4Hv0!nk3rB0Z_91YAKpSNcuYIGQiet8kixhFFs_iBX_dOswnIaN871gAIwtvVDvzKlhhdjZXGqQ$.
The files changed require a buildbot test. Buildbot has started.