SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
403 stars 225 forks source link

fixes ADIOS with variable array sizes, simultaneous runs, boundary wavefield injection #1483

Closed danielpeter closed 2 years ago

danielpeter commented 2 years ago

ADIOS wavefield compression for undo_att snapshot files has corresponding options in constants.h file

buildbot-princeton commented 2 years ago

The following files in your commit contain non-ASCII characters: src/shared/adios_manager.F90 This message is a warning only as this will be fixed by the automatic run of the code beautifier Under Linux, one way to check for non-ASCII characters is: grep --color='auto' -P -n "[\x80-\xFF]" src/shared/adios_manager.F90 This will give you the line number, and will highlight non-ASCII chars in red.

To convert the non-ASCII characters automatically, under Linux, you can use: iconv -f utf-8 -t ASCII//TRANSLIT src/shared/adios_manager.F90-o src/shared/adios_manager.F90 Although you should be aware that some characters won't be converted properly.

buildbot-princeton commented 2 years ago

The files changed require a buildbot test. Buildbot has started.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1483 (e0b72b5) into devel (ba858b8) will increase coverage by 0.04%. The diff coverage is 65.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1483      +/-   ##
==========================================
+ Coverage   45.79%   45.83%   +0.04%     
==========================================
  Files         249      249              
  Lines       54881    54998     +117     
==========================================
+ Hits        25133    25211      +78     
- Misses      29748    29787      +39     
Impacted Files Coverage Δ
src/auxiliaries/combine_vol_data.F90 0.00% <0.00%> (ø)
src/auxiliaries/combine_vol_data_impl.f90 25.42% <ø> (+2.69%) :arrow_up:
src/decompose_mesh/part_decompose_mesh.F90 64.97% <ø> (ø)
src/decompose_mesh/program_decompose_mesh.f90 70.27% <ø> (ø)
src/decompose_mesh/read_mesh_files.F90 79.75% <ø> (ø)
src/shared/adios_manager.F90 0.00% <ø> (ø)
src/shared/parallel.f90 60.73% <0.00%> (-0.76%) :arrow_down:
src/shared/param_reader.c 62.16% <ø> (ø)
src/shared/serial.f90 47.08% <0.00%> (-0.60%) :arrow_down:
...cfem3D/compute_forces_acoustic_calling_routine.f90 53.63% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba858b8...e0b72b5. Read the comment docs.

buildbot-princeton commented 2 years ago

Your changes passed the buildbot test. See build 919.

danielpeter commented 2 years ago

accept

On 6 Mar 2022, at 10:32 PM, buildbot-princeton @.**@.>> wrote:

Your changes passed the buildbot test. See build 919https://urldefense.com/v3/__http://specfem3d-buildbot.princeton.edu/builders/specfem3d_builder/builds/919__;!!Nmw4Hv0!i06fQNOZPOoftPPwXWAQkpLYIJ9AO6-i6pg71tdG4zUsOb4GQYDi7-cW2ytuwm9piRohzw$.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/geodynamics/specfem3d/pull/1483*issuecomment-1060025185__;Iw!!Nmw4Hv0!i06fQNOZPOoftPPwXWAQkpLYIJ9AO6-i6pg71tdG4zUsOb4GQYDi7-cW2ytuwm8JiJc_4Q$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABMLXWLPJOYX6MLGLWNOY43U6UB5JANCNFSM5QBP3CIQ__;!!Nmw4Hv0!i06fQNOZPOoftPPwXWAQkpLYIJ9AO6-i6pg71tdG4zUsOb4GQYDi7-cW2ytuwm9rWiSxxQ$. You are receiving this because you authored the thread.Message ID: @.***>