SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
409 stars 227 forks source link

Tutorial fixes as new pull request #1542

Closed gassmoeller closed 1 year ago

gassmoeller commented 1 year ago

These are all the fixes in the closed pull requests by @foivoskar, @liuqinya, @carltape, and @ykane. (#1537,#1538,#1539,#1540).

All: Sorry that your PRs were closed automatically, this was a consequence of the improvised nature of the tutorial, we had not considered what would happen if everyone made changes at the same time on the same branch. We will think about how to improve this process.

I have taken all of your commits and integrated them into this pull request. So although it will appear as my pull request, you will still be listed as authors in specfem's git history and you do not need to redo your changes.

@ykane: I have a question about your change, you deleted the file EXTERNAL_PACKAGES_coupled_with_SPECFEM3D/AxiSEM_for_SPECFEM3D/UTILS_COUPLING_SpecFEM/config.h instead of moving it into the new directory. Was that on purpose or an accident? I can add it again here if necessary.

buildbot-princeton commented 1 year ago

The files changed require a buildbot test. Buildbot has started.

buildbot-princeton commented 1 year ago

Your changes passed the buildbot test. See build 932.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1542 (e489012) into devel (305d428) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #1542   +/-   ##
=======================================
  Coverage   45.69%   45.69%           
=======================================
  Files         249      249           
  Lines       55308    55308           
=======================================
  Hits        25271    25271           
  Misses      30037    30037           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

danielpeter commented 1 year ago

accept

On 28 Oct 2022, at 6:24 PM, buildbot-princeton @.***> wrote:

Your changes passed the buildbot test. See build 932 https://urldefense.com/v3/__http://specfem3d-buildbot.princeton.edu/builders/specfem3d_builder/builds/932__;!!Nmw4Hv0!yhYPKLpjsZaVoozGROtgUYoOT0hXMCORTVeLvCUnAUfm_aYV8vQppQsCwQfrKR_8i497oiOx_s15OzxwSPEXjyP6jKsCngg$.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/geodynamics/specfem3d/pull/1542*issuecomment-1295552606__;Iw!!Nmw4Hv0!yhYPKLpjsZaVoozGROtgUYoOT0hXMCORTVeLvCUnAUfm_aYV8vQppQsCwQfrKR_8i497oiOx_s15OzxwSPEXjyP6mIgDzus$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABMLXWLFRETQKIZG4XCOHELWFRHDFANCNFSM6AAAAAARROSEYU__;!!Nmw4Hv0!yhYPKLpjsZaVoozGROtgUYoOT0hXMCORTVeLvCUnAUfm_aYV8vQppQsCwQfrKR_8i497oiOx_s15OzxwSPEXjyP6qzGCsHs$. You are receiving this because you are subscribed to this thread.

danielpeter commented 1 year ago

great, thanks Rene for putting it all together!