codecov-commenter
commented
1 year ago Codecov Report
Merging #1545 (5937499) into devel (8d5a058) will increase coverage by
45.69%. The diff coverage isn/a.
@@ Coverage Diff @@
## devel #1545 +/- ##
==========================================
+ Coverage 0 45.69% +45.69%
==========================================
Files 0 249 +249
Lines 0 55308 +55308
==========================================
+ Hits 0 25271 +25271
- Misses 0 30037 +30037 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/auxiliaries/combine_surf_data.f90 | 0.00% <ø> (ø) |
|
| src/auxiliaries/combine_vol_data.F90 | 0.00% <ø> (ø) |
|
| src/auxiliaries/combine_vol_data_impl.f90 | 25.42% <ø> (ø) |
|
| src/auxiliaries/combine_vol_data_vtk_binary.F90 | 0.00% <ø> (ø) |
|
| src/auxiliaries/convolve_source_timefunction.f90 | 0.00% <ø> (ø) |
|
| ...c/auxiliaries/create_movie_shakemap_AVS_DX_GMT.f90 | 18.93% <ø> (ø) |
|
| ...s/project_and_combine_vol_data_on_regular_grid.f90 | 0.00% <ø> (ø) |
|
| src/auxiliaries/vtk_writer.c | 0.00% <ø> (ø) |
|
| ...c/check_mesh_quality/convert_skewness_to_angle.f90 | 0.00% <ø> (ø) |
|
| src/decompose_mesh/check_valence.F90 | 97.01% <ø> (ø) |
|
| ... and 378 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I had some time in the plane to work on #1529. This was more complicated than I had anticipated. There were already a variety of different version numbers and even names of the package floating around in different files (a consequence of having information that often changes in the part of the file that is always copied-pasted and never checked). I added a new file VERSION in the main directory instead that is now the single place that indicates the current version number. I set that to 3.0 to be consistent with the previous headers. Many projects usually call their development version between two versions differently, to distinguish if you are on an official release (e.g. 3.0, 3.1) or on a development version prior to a release (e.g.
3.1.precould be appropriate for SPECFEM3D right now). But that is something that can now be changed easily at any time, because the only change is in one file.In a later follow up we should also unify the copyright notices, there are currently different ones (depending on the version they were introduced in).