SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
409 stars 227 forks source link

Corrections/modifications to the writing of anisotropic parameters' kernels #1565

Closed aakash10gupta closed 1 year ago

aakash10gupta commented 1 year ago

This pull request contains -

  1. Removing fortran interfaces from save_adjoint_kernels.f90 .
  2. Breaking elastic kernels' write out into two separate subroutines -
    • isotropic parameters' kernels.
    • anisotropic parmeters' kernels.
  3. Corrections to kernel computations when background model is anisotropic.
  4. Splitting 5 dimensional c_ijkl kernel array write out into 21 x 4 dimensional C_ij kernel array write out.
  5. Other minor updates.
buildbot-princeton commented 1 year ago

The files changed require a buildbot test. Buildbot has started.

buildbot-princeton commented 1 year ago

Your changes passed the buildbot test. See build 936.

codecov-commenter commented 1 year ago

Codecov Report

Base: 45.69% // Head: 45.52% // Decreases project coverage by -0.16% :warning:

Coverage data is based on head (53c2a91) compared to base (f842e9b). Patch coverage: 21.80% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #1565 +/- ## ========================================== - Coverage 45.69% 45.52% -0.17% ========================================== Files 249 249 Lines 55382 55567 +185 ========================================== - Hits 25305 25296 -9 - Misses 30077 30271 +194 ``` | [Impacted Files](https://codecov.io/gh/SPECFEM/specfem3d/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM) | Coverage Δ | | |---|---|---| | [src/shared/adios\_method\_stubs.c](https://codecov.io/gh/SPECFEM/specfem3d/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL3NoYXJlZC9hZGlvc19tZXRob2Rfc3R1YnMuYw==) | `0.00% <0.00%> (ø)` | | | [src/specfem3D/save\_adjoint\_kernels.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL3NwZWNmZW0zRC9zYXZlX2Fkam9pbnRfa2VybmVscy5mOTA=) | `23.01% <22.01%> (-11.86%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielpeter commented 1 year ago

accept

On 24 Nov 2022, at 7:19 AM, buildbot-princeton @.**@.>> wrote:

Your changes passed the buildbot test. See build 936https://urldefense.com/v3/__http://specfem3d-buildbot.princeton.edu/builders/specfem3d_builder/builds/936__;!!Nmw4Hv0!3cMJrlLJFx3oIlgO_bZjgGVRFj8Ku_kow_ZCb2njbzt-Ea8Bo1ghkUifsk32iKl7TSEesZCBpO21nwx9CQZYrcPMFy7NV6k$.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/SPECFEM/specfem3d/pull/1565*issuecomment-1325937874__;Iw!!Nmw4Hv0!3cMJrlLJFx3oIlgO_bZjgGVRFj8Ku_kow_ZCb2njbzt-Ea8Bo1ghkUifsk32iKl7TSEesZCBpO21nwx9CQZYrcPM8MOQE7w$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABMLXWM5EVYBVGTZVTOZFGDWJ3UGLANCNFSM6AAAAAASJVP3KU__;!!Nmw4Hv0!3cMJrlLJFx3oIlgO_bZjgGVRFj8Ku_kow_ZCb2njbzt-Ea8Bo1ghkUifsk32iKl7TSEesZCBpO21nwx9CQZYrcPMdKng6qs$. You are receiving this because you are subscribed to this thread.Message ID: @.***>