search

SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
390 stars 223 forks source link

Storing receiver-side 3D Greens function and strain Greens function #1573

Closed Liang-Ding closed 1 year ago

Liang-Ding commented 1 year ago

The following parameters in Par_file should be set to store the receiver-side 3D Greens function and strain Greens function: SIMULATION_TYPE = 1 SAVE_FORWARD = .true. ATTENUATION = .true. SAVE_FORWARD_BY_STEP = .true. STEP_INTERVAL_SAVE_FORWARD = 50

buildbot-princeton commented 1 year ago

The files changed require a buildbot test. Buildbot has started.

danielpeter commented 1 year ago

also, in this particular case and since there is no documentation yet on what the parameters are useful for in the manual, I would go with setting a default value (.false.) in the shared_par module for the parameters and only overwrite them if they are provided in the Par_file. then you don't have to add these parameters to all the other Par_files.

finally, the feature should be documented and explained by an example whenever ready.

buildbot-princeton commented 1 year ago

Your changes passed the buildbot test. See build 939.

danielpeter commented 1 year ago

will close this one for now. and wait for a new PR that considers renaming the parameters (see comment https://github.com/SPECFEM/specfem3d/pull/1572#issuecomment-1332768325) and avoid changing all parameter files until the feature is documented.