SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
390 stars 223 forks source link

Updates to user manual, slurm scripts, model reading, and adjoint kernels' computation #1578

Closed aakash10gupta closed 1 year ago

aakash10gupta commented 1 year ago

This pull request contains the following updates -

  1. User manual - removes obsolete parameters' descriptions
  2. Slurm scripts - updates parameter reading from Par_file, and the 'if ' statements
  3. Model reading -
    • initializes anisotropy variables in model_default.f90
    • updates array usage in reading anisotropic tomographic models
  4. Adjoint kernels' computation -
    • consistent use of the 'type' of coefficients in the equations with better readability
    • correction for equation of 'eta' for transverse isotropic models
buildbot-princeton commented 1 year ago

The files changed require a buildbot test. Buildbot has started.

codecov-commenter commented 1 year ago

Codecov Report

Base: 45.56% // Head: 45.59% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (6fd6cee) compared to base (1a352a6). Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #1578 +/- ## ========================================== + Coverage 45.56% 45.59% +0.03% ========================================== Files 247 249 +2 Lines 55268 55527 +259 ========================================== + Hits 25182 25317 +135 - Misses 30086 30210 +124 ``` | [Impacted Files](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM) | Coverage Δ | | |---|---|---| | [src/generate\_databases/model\_tomography.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2dlbmVyYXRlX2RhdGFiYXNlcy9tb2RlbF90b21vZ3JhcGh5LmY5MA==) | `63.13% <0.00%> (+0.37%)` | :arrow_up: | | [src/specfem3D/save\_adjoint\_kernels.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL3NwZWNmZW0zRC9zYXZlX2Fkam9pbnRfa2VybmVscy5mOTA=) | `22.76% <25.00%> (ø)` | | | [src/generate\_databases/model\_default.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2dlbmVyYXRlX2RhdGFiYXNlcy9tb2RlbF9kZWZhdWx0LmY5MA==) | `94.25% <100.00%> (+1.82%)` | :arrow_up: | | [src/decompose\_mesh/partition\_scotch.F90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2RlY29tcG9zZV9tZXNoL3BhcnRpdGlvbl9zY290Y2guRjkw) | `13.47% <0.00%> (-0.20%)` | :arrow_down: | | [src/specfem3D/convert\_time.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL3NwZWNmZW0zRC9jb252ZXJ0X3RpbWUuZjkw) | `66.29% <0.00%> (ø)` | | | [src/shared/serial.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL3NoYXJlZC9zZXJpYWwuZjkw) | `47.08% <0.00%> (ø)` | | | [src/generate\_databases/model\_sep\_nompi.f90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2dlbmVyYXRlX2RhdGFiYXNlcy9tb2RlbF9zZXBfbm9tcGkuZjkw) | `0.00% <0.00%> (ø)` | | | [src/decompose\_mesh/decompose\_mesh.F90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2RlY29tcG9zZV9tZXNoL2RlY29tcG9zZV9tZXNoLkY5MA==) | `72.06% <0.00%> (+0.55%)` | :arrow_up: | | [src/decompose\_mesh/write\_mesh\_databases.F90](https://codecov.io/gh/SPECFEM/specfem3d/pull/1578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM#diff-c3JjL2RlY29tcG9zZV9tZXNoL3dyaXRlX21lc2hfZGF0YWJhc2VzLkY5MA==) | `87.69% <0.00%> (+3.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

buildbot-princeton commented 1 year ago

Your changes passed the buildbot test. See build 940.

danielpeter commented 1 year ago

accept

On 3 Dec 2022, at 6:42 AM, buildbot-princeton @.***> wrote:

Your changes passed the buildbot test. See build 940 https://urldefense.com/v3/__http://specfem3d-buildbot.princeton.edu/builders/specfem3d_builder/builds/940__;!!Nmw4Hv0!1UTqBQKgeV_L3rRRZR-TtRwwnHXEchteyZKt-TMUuHAefl2I7lSlEBs_5gEeNQRGGhFN2BK3jUF-MhnSJ6y8lBsbCfMJTNc$.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/SPECFEM/specfem3d/pull/1578*issuecomment-1336035107__;Iw!!Nmw4Hv0!1UTqBQKgeV_L3rRRZR-TtRwwnHXEchteyZKt-TMUuHAefl2I7lSlEBs_5gEeNQRGGhFN2BK3jUF-MhnSJ6y8lBsbXd0JCrc$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABMLXWJJVRPQQBOFGZBBVHLWLK6S5ANCNFSM6AAAAAASSQBJKI__;!!Nmw4Hv0!1UTqBQKgeV_L3rRRZR-TtRwwnHXEchteyZKt-TMUuHAefl2I7lSlEBs_5gEeNQRGGhFN2BK3jUF-MhnSJ6y8lBsbXGfybGY$. You are receiving this because you are subscribed to this thread.