search

SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
390 stars 223 forks source link

Fix HIP_PLATFORM macros #1637

Closed gargrahul closed 8 months ago

gargrahul commented 8 months ago

Replace HIP_PLATFORM_HCC to HIP_PLATFORM_AMD and HIP_PLATFORM_NVCC to HIP_PLATFORM_NVIDIA

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d2105bb) 0.00% compared to head (7e0db64) 48.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #1637 +/- ## ========================================== + Coverage 0 48.39% +48.39% ========================================== Files 0 266 +266 Lines 0 60094 +60094 ========================================== + Hits 0 29083 +29083 - Misses 0 31011 +31011 ``` [see 266 files with indirect coverage changes](https://app.codecov.io/gh/SPECFEM/specfem3d/pull/1637/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SPECFEM)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielpeter commented 8 months ago

update for latest ROCm platform 5.7.1 version: https://rocm.docs.amd.com/projects/HIP/en/latest/user_guide/hip_porting_guide.html#identifying-hip-target-platform

pramenku commented 8 months ago

Hi @danielpeter When this PR can be merged to master branch?

danielpeter commented 8 months ago

there is no scheduled release yet (the master branch is the "official" release). however, I thought to update the master soon - somewhen in november. do you have any preference/dependence on this master release?

pramenku commented 8 months ago

@danielpeter yes, We use master branch to test internally. So before next rocm gets released, we want to make sure, it has been properly tested. If you can merge by this week or early next week, will.be great help.

Also, this changes are backward compatible so 5.7 user will not face the issue