search

SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
409 stars 227 forks source link

Brune and Smoothed Brune source time functions #1649

Closed homnath closed 10 months ago

homnath commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (fb8310f) 51.51% compared to head (6c57e3f) 51.48%.

Files Patch % Lines
src/specfem3D/comp_source_time_function.f90 0.00% 14 Missing :warning:
src/specfem3D/locate_source.F90 0.00% 6 Missing :warning:
src/specfem3D/compute_add_sources_viscoelastic.F90 0.00% 4 Missing :warning:
src/specfem3D/get_force.f90 0.00% 4 Missing :warning:
src/specfem3D/setup_sources_receivers.f90 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #1649 +/- ## ========================================== - Coverage 51.51% 51.48% -0.03% ========================================== Files 266 266 Lines 60104 60134 +30 ========================================== - Hits 30961 30959 -2 - Misses 29143 29175 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jpampuero commented 10 months ago

Hi Hom Nath. These new Brune STFs are moment functions (they tend to a non-zero value at long times), whereas the other ones in the code are moment RATE functions (they go back to zero at long times). That could be confusing for users. Is that intentional?

homnath commented 10 months ago

@jpampuero Hi Pablo, Thank you so much for the important feedback. I have just implemented them for testing purposes. Please let us know how to implement them more accurately and efficiently. Best, Hom Nath

jpampuero commented 10 months ago

To make it a moment rate, you just need to replace the function by its time derivative. P

danielpeter commented 10 months ago

closing the PR - mainly because of the DATA/ and m4/ changes that seem to be unrelated and by mistake