search

SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).
GNU General Public License v3.0
412 stars 229 forks source link

Bug running adjoint simulation with binary seismograms #487

Closed EtienneBachmann closed 7 years ago

EtienneBachmann commented 9 years ago

Hello everybody, There is currently an error for adjoint simulations with flags SU_FORMAT=.false. and SEISMOGRAMS_BINARY = .true. When checking the size of the seismo binary files in "setup_source_receivers" and reading adjoint source in "compute_array_sources", the code is not written to manage binary files. Is it a planned future work? Thanks

komatits commented 7 years ago

Hi all,

Etienne's recent bug fixes maybe/likely fixed this small bug as well (?). @EtienneBachmann

Cheers, Dimitri.

EtienneBachmann commented 7 years ago

Hi Dimitri,

My last commit didn't fix it, but I guess that instead of implementing it, we should print an error message like " Adjoint simulations not supported with .bin format, please use SU instead".

I'll do it soon.

Best,

Etienne

komatits commented 7 years ago

Hi Etienne,

I agree, good idea :-) I will then accept the pull request.

Thanks, Best,

Dimitri.

On 06/05/2017 07:13 PM, EtienneBachmann wrote:

Hi Dimitri,

My last commit didn't fix it, but I guess that instead of implementing it, we should print an error message like " Adjoint simulations not supported with .bin format, please use SU instead".

I'll do it soon.

Best,

Etienne

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/geodynamics/specfem3d/issues/487#issuecomment-306247123, or mute the thread https://github.com/notifications/unsubscribe-auth/AFjDKTCgbXKcX13jIO7F0KrK4H-nNasKks5sBDdPgaJpZM4EAPqe.

-- Dimitri Komatitsch, CNRS Research Director (DR CNRS) Laboratory of Mechanics and Acoustics, Marseille, France http://komatitsch.free.fr

komatits commented 7 years ago

Fixed by Etienne @EtienneBachmann