search

SPECFEM / specfem3d_globe

SPECFEM3D_GLOBE simulates global and regional (continental-scale) seismic wave propagation.
GNU General Public License v3.0
90 stars 95 forks source link

Missing line in Parfile (in the "master" branch only) #174

Closed MMesch closed 9 years ago

MMesch commented 10 years ago

in the DATA/Parfile, the line:

"NT_DUMP_ATTENUATION = 100 " after line: "UNDO_ATTENUATION = .false."

is missing (by accident?)

komatits commented 10 years ago

Hi Matthias,

Just upgrade to the latest version of the "devel" code, and in the DATA directory you will find the current version of the Par_file (in which NT_DUMP_ATTENUATION has been suppressed, it is now computed automatically by the code; other parameters have been added).

Best wishes, Dimitri.

On 09/07/2014 17:14, MatthiasMeschede wrote:

in the DATA/Parfile, the line:

"NT_DUMP_ATTENUATION = 100 " after line: "UNDO_ATTENUATION = .false."

is missing (by accident?)

— Reply to this email directly or view it on GitHub https://github.com/geodynamics/specfem3d_globe/issues/174.

Dimitri Komatitsch CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics, UPR 7051, Marseille, France http://komatitsch.free.fr

MMesch commented 10 years ago

ok thank you Dimiti! I just wanted to report that the master branch doesn't work out of the box.

komatits commented 10 years ago

Hi Matthias,

Thanks a lot! I thought you were talking about the "devel" branch (I never use the master branch myself).

Eric or David, could you thus merge "devel" into "master", since it seems "master" does not work because some lines are missing in the Par_files? "devel" works fine for sure.

Thanks, Dimitri.

On 10/07/2014 10:46, MatthiasMeschede wrote:

ok thank you Dimiti! I just wanted to report that the master branch doesn't work out of the box.

— Reply to this email directly or view it on GitHub https://github.com/geodynamics/specfem3d_globe/issues/174#issuecomment-48579299.

Dimitri Komatitsch CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics, UPR 7051, Marseille, France http://komatitsch.free.fr

komatits commented 10 years ago

Hi Eric, @eheien

When you have time, could you please merge "devel" into "master" for SPECFEM3D_GLOBE and then close this GitHub issue?

Thank you very much, Best regards, Dimitri.

eheien commented 9 years ago

Hi Dimitri,

Sorry, I lost track of this. Is devel still in a good state to merge to master, or should I wait?

-Eric

On Jul 30, 2014, at 4:08 PM, Dimitri Komatitsch notifications@github.com wrote:

Hi Eric, @eheien

When you have time, could you please merge "devel" into "master" for SPECFEM3D_GLOBE and then close this GitHub issue?

Thank you very much, Best regards, Dimitri.

— Reply to this email directly or view it on GitHub.

komatits commented 9 years ago

Hi Eric,

For this one let us wait a bit more because I had to temporarily comment out one set of executables in the Makefile of the devel branch (see https://github.com/geodynamics/specfem3d_globe/pull/222 ).

Hopefully somebody familiar with the build system will be able to fix that (and after that it will be OK to merge devel into master for SPECFEM3D_GLOBE.

Regarding SPECFEM2D devel is stable and thus it is OK to merge it today.

Thanks, Dimitri.

On 06/09/2014 18:26, Eric Heien wrote:

Hi Dimitri,

Sorry, I lost track of this. Is devel still in a good state to merge to master, or should I wait?

-Eric

On Jul 30, 2014, at 4:08 PM, Dimitri Komatitsch notifications@github.com wrote:

Hi Eric, @eheien

When you have time, could you please merge "devel" into "master" for SPECFEM3D_GLOBE and then close this GitHub issue?

Thank you very much, Best regards, Dimitri.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/geodynamics/specfem3d_globe/issues/174#issuecomment-54718665.

Dimitri Komatitsch CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics, UPR 7051, Marseille, France http://komatitsch.free.fr

eheien commented 9 years ago

I merged devel into master for SPECFEM2D and SPECFEM3D_Globe.