search

SPF-OST / pytrnsys

Package that provides functionality to run and process, plot and report TRNSYS simulations
https://pytrnsys.readthedocs.io
GNU General Public License v3.0
11 stars 8 forks source link

Processing crashes while reading csv file (nRows must be integer >= 0) #182

Closed ahobeost closed 8 months ago

ahobeost commented 8 months ago

As a User, I would like the post-processing to be more forgiving. An issue with one file can stop the post-processing of an entire parameter study.

https://github.com/SPF-OST/pytrnsys/blob/master/pytrnsys/psim/simulationLoader.py image

An example file in question belongs to a "failed" simulation. Instead of a year, it only simulated one month: image

The files of a "successful" simulation are much longer: image

Thus, it would make sense to only process "successful" simulations.

ahobeost commented 8 months ago

Raising the error in a try, except block seems to stop the one process without crashing all processes. This seems strange to me, as it is the same error.

zuckerruebe commented 8 months ago

That's fixed in the newest version.