search

SPF-OST / pytrnsys

Package that provides functionality to run and process, plot and report TRNSYS simulations
https://pytrnsys.readthedocs.io
GNU General Public License v3.0
11 stars 8 forks source link

Color data points in comfortHourly according to season #88

Closed martin-neugebauer closed 2 years ago

martin-neugebauer commented 2 years ago

image As a user I would like the data points to be colored according to the month they occurred: Dec-Feb Mar-May Jun-Aug Sep-Nov

martin-neugebauer commented 2 years ago

@DanielPhilippen @ToniCal18

DanielPhilippen commented 2 years ago

Martin, after you left today, we discussed also the boundaries/comfort zones: for me they are quite odd. 17 °C won't be accepted in winter as people will feel cold. Maybe it's something physiological: 17 °C are okay for the nose if the air is humid? So, the zones should be modifiable as well :)

martin-neugebauer commented 2 years ago

I agree that they are odd, but they were simply taken from the respective publication. The boundaries are adjustable in the python source code, but I really wouldn't make them controllable from the config-file, since this will just lead to long command lines. I guess we don't want to change them from plot to plot, but just find correct ones once and keep them.

ToniCal18 commented 2 years ago

I agree 100% on that Martin. The plots come from publications and we should keep them as they are. To present our simulation results in terms of comfort, maybe we could simply use the other plot (according to ISO7730) already available that seems to be more plausible. Anyway as soon as Daniel clarifies with CVUT definition/norms in terms of comfort for Czech Republic maybe we could simply implement another plot according to Czech norms if necessary.

martin-neugebauer commented 2 years ago

Yes, additional norms are no problem. 👍