search

SPF-OST / pytrnsys_gui

Graphical user interface for pytrnsys
https://pytrnsys.readthedocs.io
GNU General Public License v3.0
3 stars 4 forks source link

Partially broken mass flow visualizer #323

Open martin-neugebauer opened 2 years ago

martin-neugebauer commented 2 years ago

Before commit bbb72d21f7965eced4d9545baa0f482463571783 the attached mass flow rate and temperatures mfrIssue.zip could be visualized in pytrnsys_trihp\pytrnsys_trihp\pycharm\slurry_system\slurry_system.json, now this is not possible anymore. This is somewhat a special case, since some pipe names are differnet between the hydraulic scheme and the prt files. Before, however, it was still possible to visualize for pipes that have matching names.

martin-neugebauer commented 2 years ago

@ignasigurruchagagarcia @maikeSchubert I made an issue for the problem you encountered. @zuckerruebe Could you maybe have a look? I'm not sure we want to fix this, since having pipes names differ between the scheme and the prt-files is not really standard behavior.

zuckerruebe commented 1 year ago

After clicking away a warning telling the user that the variables don't match exactly, she should be able to visualize the mass flows etc. regardless -> change implementation.