SPF-OST / pytrnsys_gui

Graphical user interface for pytrnsys
https://pytrnsys.readthedocs.io
GNU General Public License v3.0
3 stars 4 forks source link

Add visual clarity to the usage of tVentil -> teeValve #380

Open ahobeost opened 1 year ago

ahobeost commented 1 year ago

The name should be English.

The following image is a first draft of what would make this visually clear; grafik

Highlighting the chosen version would be a next step.

For usability, it would be great if the users could click on the images. Reactive percentages for the divided flow would be helpful.

zuckerruebe commented 1 year ago

My 2 cents:

  1. Maybe just use images 3 and 4 and make image 3 more general by replacing the actual 0.6 by the general f (and (1-f), respectively)?
  2. What about mixing valves (where the black port is an outlet)? [How do they actually work? What, then, means f = 0.75? Because it's not in the valve's control whether m_out == m_in_1*(1-f) + m_in_2*f
zuckerruebe commented 1 year ago
2. What about mixing valves (where the black port is an outlet)? [How do they actually work? What, then, means `f = 0.75`? Because it's not in the valve's control whether `m_out == m_in_1*(1-f) + m_in_2*f`

So it seems the valve cannot control it but it enforces it. I.e. given a demanded mass flow at the black port and the input temperatures at the gray ports a tempering valves sets its f in such a way that the set point temperature at the black port is achieved. Whether the actual massflows at the inputs satisfy the f has to be made sure in the rest of the system.

ahobeost commented 1 year ago

Currently, the "library view" of different diagram components isn't tested. Changing the name of tVentil in all instances to a proper English implementation will be quite involved