search

SPF-OST / pytrnsys_gui

Graphical user interface for pytrnsys
https://pytrnsys.readthedocs.io
GNU Lesser General Public License v3.0
3 stars 4 forks source link

Get rid of `dev` tag for `pytrnsys-gui` egg in developer install #390

Open zuckerruebe opened 1 year ago

zuckerruebe commented 1 year ago

As a developer I want to replace the current mechanism of indicating whether the GUI is run from within a developer install with something more robust (the tag needs to be re-added every time pytrnsys-gui is upgraded/re-installed which happens, e.g., every time we do python -m piptools sync)

Currently, whe tag the pytrnsys-gui egg (see step 5. here https://github.com/SPF-OST/pytrnsys_gui#getting-started) to indicate that the current install is a developer installation. If that tag is around, we do things like checking whether all required packages are installed and re-run the script that generates Python code from Qt Creator .ui files.

I think we should replace the if hasDevTag() check with an if not isRunAsExe() check. I.e. only support two kinds of installations:

  1. Developer install: from source, using git
  2. User install: download a release or latest bleeding edge .exe file

For a developer install we should check for missing packages and regenerate UI Python code, for the .exe not so.

zuckerruebe commented 1 year ago

@ahobeost