Allow visualization of mass flow solver files which aren't named after the current project

SPF-OST / pytrnsys_gui

Graphical user interface for pytrnsys

https://pytrnsys.readthedocs.io

GNU Lesser General Public License v3.0

3 stars 4 forks source link

Allow visualization of mass flow solver files which aren't named after the current project #449

Open zuckerruebe opened 1 year ago

zuckerruebe commented 1 year ago

As a user, I run the mass flow solver in different configurations (valve positions, pumping powers, etc). Then, I'd like to save the resulting _.prt files under different names, e.g.: myProjectVar1_Mfr.prt, myProjectVar2_Mfr.prt so that I can visualize them in the diagram later on. I cannot do that, ATM, because I can only load mass flow solver .prt files which are named after the project (i.e. myProject_Mfr.prt in the above example). This restriction should be removed.

ahobeost commented 1 year ago

Upon further investigation, this use case is currently possible.

The following needs to be done to make this work:

rename the *Mfr.prt file, e.g., myProjectVar1_Mfr.prt
rename the T.prt file to conform to the name of the Mfr.prt file. myProjectVar1_Mfr.prt -> myProjectVar1_T.prt

The issue lies with the user feedback.

When only the *Mfr.prt file is renamed, And this file is chosen to be visualized in the GUI, Then nothing seems to happen in the GUI. Instead, an unclear message is send to the log file (now visible in the logger console in the GUI). "No mfrFile or tempFile found!"

ahobeost commented 1 year ago

Suggested improvements:

[ ] Improve the message, e.g., "Couldn't find the Temperature file ({name}_T.prt) corresponding to the mass-flow-rate file ({name}_Mfr.prt). When renaming these files, ensure that both the Mft.prt file and the T.prt file are renamed in an identical fashion."
[ ] Open a messageBox with this message as feedback to the used.