search

SPF-UiO / spbm

The Student Personnel Booking Manager, by and for the Student Cellar Pub Personnel Organsiation at the University of Oslo.
6 stars 4 forks source link

Problem with inactivating workers #15

Open myrishpyrish opened 6 years ago

myrishpyrish commented 6 years ago

I can´t seem to find out how to inactivate a worker. I have tried selecting one worker and clicking "edit", but the option of inactivating (or de-selecting "Active") does not exist.

thor commented 6 years ago

This is more or less a regression from c67457529d07390073e0d4b9b9214aa587006946, although also later commits when it was actually migrated from the old ManyToOneField to the ManyToManyfield.

I'll have to create, or add, a way to deactivate a particular Employment, or alternatively make a neat little button that just deactivates an employee? Hm, that would possibly be simpler from a booking manager's point of view.

Feedback/ideas are welcome! @maxiix3? ;)

maxiix3 commented 6 years ago

What about a "remove from society" button? When the employeer have no active society the system deletes the person? So everytime you press remove from society there is a test to see if the person is assosiated somewhere, if not -> delete?

Can see if I have some spare time during the easter and implement something :)

thor commented 6 years ago

Possibly something like that, yeah! Although, once a worker has been registered for an event, it can never be truly deleted, so I feel like deletion is only applicable if the event can be cancelled. Post that, it's in the records forever.

maxiix3 commented 6 years ago

oh, didn't think about that.. But if the worker isn't assosiated somewhere, who would find the employee anyways? Only the administrator or someone who wants to add the person? i.e deleted ?