SPI-Birds / pipelines

Pipelines for generating a standard data format for bird data
2 stars 6 forks source link

add "TEST" to the first line #197

Open ameliefar opened 1 year ago

ameliefar commented 1 year ago

(from my personal computer)

LiamDBailey commented 1 year ago

@ameliefar Looks to be working well!! Next, try requesting a review from Stefan or me (in the top right).

ameliefar commented 1 year ago

Sorry for all of this, I'm trying to figure out why I can't click on "reviewers"

LiamDBailey commented 1 year ago

This is what it looks like to me (below). It might be because you don't have admin privileges here. In worst case scenario, we can assign the reviewers instead, although that's not ideal!

space

LiamDBailey commented 1 year ago

If that definitely doesn't work for you, we can try adding you with some limited privileges that allow you to manage pull requests. Let me know if you have some success!

ameliefar commented 1 year ago

Here is a print screen showing what I have on the right side bar. I can't click on "reviewers" (my only option is "convert to draft"

ScreenPrint_reviewers

StefanVriend commented 1 year ago

This is what I find in relation to requesting a pull request review in the Github documentation (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review):

image

LiamDBailey commented 1 year ago

Ok, so seems that at this stage @ameliefar wouldn't be able to assign (or be assigned) a reviewer. Is this a problem? Perhaps not, because Stefan or I can assign reviewers once we know the PR exists (if you send a message or tag us in a comment). We can, of course, give @ameliefar write access, but if we want to make this system more general (also to people that we might not know) we don't want a system where each person is expected to get write access.

What do you think @StefanVriend?

StefanVriend commented 1 year ago

In light of making things more general (and secure), I think your first suggestion is the best option. I guess it will be rather undemanding, as it shouldn't require more than a few clicks for us to assign a reviewer.

ameliefar commented 1 year ago

@LiamDBailey @StefanVriend - I was just checking I could also do the process from my lab computer.