search

SPOClab-ca / BENDR

170 stars 57 forks source link

Channel and referencing #18

Closed ywatanabe1989 closed 1 year ago

ywatanabe1989 commented 1 year ago

Hi,

I have two questions. Specifically,

1) What is the channel order of the 10-20 system for the model? 2) Also, what is the appropriate referencing method for channels?

Thank you very much for your consideration.

ywatanabe1989 commented 1 year ago

I'm not sure but deep1010 may map channels for the standard 10-20 system. https://github.com/SPOClab-ca/dn3/blob/f6c3ddcba2a986c2021dc3efb076b1d1079d7739/dn3/transforms/channels.py

kostasde commented 1 year ago

Indeed, if channel labels follow reasonable conventions, channels should be appropriately mapped. There is a lot of log output that should confirm this while you load your data.

I can't recall too much more about it though.

kostasde commented 1 year ago

By appropriately mapped, 10-20 channels should consistently go to the indices of the deep1010 that they correspond to.

ywatanabe1989 commented 1 year ago

Thank you very much.

Unfortunately, I am applying the BENDR model to our own dataset.

Probably, is this the expected channel order? https://github.com/SPOClab-ca/dn3/blob/master/dn3/transforms/instance.py#L406-412