SQLJames / factorio-server-charts

Helm deployment for Factorio
https://artifacthub.io/packages/helm/factorio-server-charts/factorio-server-charts
The Unlicense
27 stars 29 forks source link

Issues with helm values schema #75

Open Kariton opened 1 week ago

Kariton commented 1 week ago

My current deployment does not update with the updated schema.

Error: values don't meet the specifications of the schema(s) in the following chart(s): factorio-server-charts: - map_gen_settings.seed: Invalid type. Expected: null, given: integer - map_gen_settings.starting_area: Invalid type. Expected: integer, given: number

        map_gen_settings:
          starting_area: 1.5
          peaceful_mode: false
          autoplace_controls:
            iron-ore:
              frequency: 0.50
              size: 1.50
              richness: 2
            copper-ore:
              frequency: 0.50
              size: 1.50
              richness: 2
            stone:
              frequency: 0.50
              size: 1.50
              richness: 2
            coal:
              frequency: 0.50
              size: 1.50
              richness: 2
            crude-oil:
              frequency: 0.50
              size: 1.50
              richness: 2
            uranium-ore:
              frequency: 0.50
              size: 1.50
              richness: 2
          seed: 3508092348
SQLJames commented 1 week ago

going to remove the schema and the workflow until I can come up with a better solution

76

SQLJames commented 1 week ago

Merged, 2.5.2 should be released shortly which will allow you to upgrade.

Kariton commented 5 days ago

works now. :)

SQLJames commented 5 days ago

I volunteered to take over the helm-schema-gen plugin that I used for generating schema. My goal will be to update it so that we can leverage it for this chart. It make take some time before we get there though.

For those who are interested here is the link I just finished putting together. The maintainer of the original is also stepping through it to make sure the handoff goes smoothly.

https://github.com/rhoat/helm-schema-gen