SQLUndercover / UndercoverToolbox

A collection of cool and useful tools, procedures and scripts for the discerning DBA
https://sqlundercover.com
MIT License
84 stars 40 forks source link

Inspector - BlitzWaits can highlight wait type even if the threshold is not breached #259

Closed Adedba closed 3 years ago

Adedba commented 3 years ago

Describe the bug If you have a row in the the BlitzWaits_WatchedWaitTypes table and have the threshold set to a number greater than 0 with a direction of < or > then you would not expect this wait type to be warning level highlighted if it features in the top x waits BUT not breaching the threshold, you would expect this to be present but without a warning level highlight, you would only expect to see the highlight if it breaches the threshold set.

To Reproduce Steps to reproduce the behavior: Force a wait to feature in the top x waits for a time bucket (or pick one that is already there present) Insert a row in the BlitzWaits_WatchedWaitTypes table and set the Warning level to 1 or 2 ,threshold direction to '>' and Threshold to a large number greater than the actual ms per wait for the wait type (we want to try and get it to not highlight in colour)

Run the report for the waits module and you should see the wait type present and highlighted with the warning level colour you specified in the WatchedWaitTypes table.

Expected behavior Wait type should be present but not highlighted in colour unless it has actually breached the threshold then we want it to highlight in the respective warning colour.