Request to publish container to Github Container Registry

layertwo commented 2 weeks ago

Would you consider publishing your container to Github alongside just DockerHub?

I prefer using GHCR as it allows me to quickly identify if a project has containers built rather than having to navigate away to DockerHub.

SQuent commented 2 weeks ago

Hello @layertwo,

Thanks for your interest and contribution to this project! I've switched the registry to GHCR, but I’m not entirely sure about the credentials setup—does it seem correct to you?

I'll check this during the next release and make adjustments if needed. I also noticed you’re interested in contributing a new feature; could you share a bit more about it?

layertwo commented 2 weeks ago

re: GHCR, that looks good to me. Here's what I do on my repository to push to GHCR: https://github.com/layertwo/flux/blob/mainline/.github/workflows/cloudflare-ddns-docker-image.yml#L55-L57

re: features. There's a couple ideas I have floating around, but here's some things:

Support Traefik V3 (Kubernetes CRDs API group changed: Kubernetes CRDs API Group
Support UptimeKuma API keys rather than user/passsword (already supported in the Python library)
Some refactoring to move stuff to classes - separate the business logic from the client setup logic (I'm a big fan of dependency injection)

SQuent / kuma-ingress-watcher

Request to publish container to Github Container Registry #26