search

SRA-VJTI / sra-board-component

ESP-IDF component for SRA Board
https://sravjti.in/sra-board-component/
MIT License
36 stars 20 forks source link

Function naming for char_adc1(...) #18

Closed laukik-hase closed 4 years ago

laukik-hase commented 4 years ago

https://github.com/SRA-VJTI/sra-board-component/blob/d58505f71440e80b5fe426d02a260f7a3d6b5264/src/adc.c#L48

@ombhilare999 The name of the function should be meaningful and explain its purpose.

ombhilare999 commented 4 years ago

https://github.com/SRA-VJTI/sra-board-component/blob/d58505f71440e80b5fe426d02a260f7a3d6b5264/include/adc.h#L31-L36 For Characterize ADC isn't this appropriate name(char_adc)? I have include info about this function in adc.h

SravanChittupalli commented 4 years ago

I guess 'char' is a bit misleading so I will change it to characterize ADC.

VedantParanjape commented 4 years ago

Closing this issue, it is being addressed in PR (#26 )