SRA-VJTI / sra-board-component

ESP-IDF component for SRA Board
https://sravjti.in/sra-board-component/
MIT License
36 stars 20 forks source link

Added lsa and multisampling code #26

Closed SravanChittupalli closed 4 years ago

SravanChittupalli commented 4 years ago

1) Added code to read lsa readings with multisampling 2) changed char_adc1() function name in adc.c and adc.h to characterize_adc1() for better readability

SravanChittupalli commented 4 years ago

@laukik-hase I have included reading adc and multisampling codes in a single file. So in the lsa test code i will just have to call one function. Is this good for readability or is it better to show multisampling in test code?

laukik-hase commented 4 years ago

@SravanChittupalli Rename lsa to line_sensor_array (It's ambiguous to third person). Also, is there any in-built function for multi-sampling?

SravanChittupalli commented 4 years ago

@laukik-hase I'll do the renaming part. I can't find any in-built function for multisampling in idf docs. The logic we are using is from the idf examples and they did not use any function.

laukik-hase commented 4 years ago

@laukik-hase I'll do the renaming part. I can't find any in-built function for multisampling in idf docs. The logic we are using is from the idf examples and they did not use any function.

Cool then. Just update here when its done. Also, after this you should start working on line following ASAP.

VedantParanjape commented 4 years ago

@SravanChittupalli Please do the changes requested by laukik