search

SRA-VJTI / sra-board-component

ESP-IDF component for SRA Board
https://sravjti.in/sra-board-component/
MIT License
36 stars 20 forks source link

Shouldn't these macros be defined in motor_driver.h ? #31

Closed OSSome01 closed 4 years ago

OSSome01 commented 4 years ago

https://github.com/SRA-VJTI/sra-board-component/blob/9e91c71dc8afe97e4e95312108df1b2a58c1cf31/include/pin_defs.h#L51

@VedantParanjape

VedantParanjape commented 4 years ago

Yes, right. Please add it to motor_driver.h and make a PR

VedantParanjape commented 4 years ago

Done in 6f4969545e6ba2c73958171dc0d2caa96159d652