search

SRA-VJTI / sra-board-component

ESP-IDF component for SRA Board
https://sravjti.in/sra-board-component/
MIT License
36 stars 20 forks source link

MPU Calibration #74

Closed RISHI27-dot closed 1 year ago

VedantParanjape commented 1 year ago

Still two things are not implemented. 1) void complementary_filter(int16_t acce_raw_value, int16_t gyro_raw_value, float complementary_angle, float mpu_offset) -> this doesn't internally use mpu_offset on gyro values

2) inside read_mpu6050(), call to complementary_filter function doesn't use the offset values defined above.

SAtacker commented 1 year ago

Can you please mark the review as resolved if you have did it @RISHI27-dot ?

VedantParanjape commented 1 year ago

Other than that LGTM, @gautam-dev-maker can you do one final review?