Add Keychron Q3 HE - Githubissues

SRGBmods / qmk-plugins

Plugins to support QMK devices in SignalRGB

GNU General Public License v2.0

7 stars 9 forks source link

Add Keychron Q3 HE #8

Closed KellyNyanbinary closed 4 weeks ago

KellyNyanbinary commented 4 weeks ago

This pull request adds support for the Keychron Q3 HE. As the Q3 HE is identical in layout to the Q3 ANSI Encoder, the plugin code for the Q3 ANSI Encoder is utilized as a base.

The only things modified are:

Changing ProductID() to return 0x0b30 for the Q3 HE
Changing Publisher to me (feel free to revert this if my changes are too insignificant)

[!note] The Q3 HE firmware source code has an incorrect LED configuration, so SignalRGB will apply effects incorrectly.

naitoshedo commented 4 weeks ago

Plugin has been added, as far as the firmware that is up to Keychron to push a fix as we do not modify forks if we can help it past the SRGBP support. You did the right thing by opening an issue and when they address it I will apply the fix to pre-compiled firmware.