SRGSSR / pillarbox-web-suite

A suite of plugins, themes, and components for pillarbox-web
https://srgssr.github.io/pillarbox-web-suite/
MIT License
4 stars 0 forks source link

fix: preserve default options when adding new translations #23

Closed jboix closed 4 months ago

jboix commented 4 months ago

Description

Refactored language modules to merge with existing default translations in videojs.options.language. This prevents overriding default configurations when calling videojs.addLanguage. Changes have been applied across all packages in the monorepo and the templates for the generation of new packages.

Changes Made

Checklist

github-actions[bot] commented 4 months ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 94.18% 907 / 963
🔵 Statements 94.18% 907 / 963
🔵 Functions 94.11% 64 / 68
🔵 Branches 92.92% 92 / 99
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/pillarbox-playlist/src/lang/index.js 100% 100% 100% 100%
packages/skip-button/src/lang/index.js 100% 100% 100% 100%
Generated in workflow #71
github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-10 08:15 UTC

amtins commented 4 months ago

We have found that two javascript build tools produce two different results when json files are imported with the keyword import.

This demonstrates the unnecessary complexity of the javascript ecosystem. If we add minification (which can also produce unexpected results), TypeScript and so on, we're satellized on uranus.

That's it, I just needed to share a personal emotion. JS 🚀 to Uranus

github-actions[bot] commented 4 months ago

:tada: This PR is included in version @srgssr/skip-button-v1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: