fix(srgssr-middleware): akamai token generation

SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.

https://srgssr.github.io/pillarbox-web-demo/

MIT License

12 stars 1 forks source link

fix(srgssr-middleware): akamai token generation #136

Closed amtins closed 9 months ago

amtins commented 9 months ago

Description

The Akamai token was generated for all URNs, regardless of whether or not they were protected by an Akamai token.

This was due to the fact that the return statement was missing from the condition used to check whether or not a resource was protected by an Akamai token.

Changes made

add missing return statement to the composeAkamaiResources function
add a test case checking that the token is not generated if the resource doesn't require it

github-actions[bot] commented 9 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	98.37%	482/490
🟢	Branches	93.44%	228/244
🟢	Functions	100%	136/136
🟢	Lines	99.15% (+0% 🔼)	466/470

Test suite run success

146 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 362473ba0fd2b99b59bdf6718141c2f26a9dc29d