feat(pillarbox): enable smooth seeking by default

SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.

https://srgssr.github.io/pillarbox-web-demo/

MIT License

12 stars 1 forks source link

feat(pillarbox): enable smooth seeking by default #156

Closed amtins closed 8 months ago

amtins commented 8 months ago

Description

Closes #155 by enabling smooth seeking by default for Pillarbox. This feature improves the user experience by providing smoother interaction with the progress bar.

Screencast from 03. 01. 24 15:21:49.webm

Changes made

Pillarbox options enableSmoothSeeking property is set to true
add a test case
Demo player, remove the enableSmoothSeeking from DEFAULT_OPTIONS

github-actions[bot] commented 8 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	98.37% (+0% 🔼)	483/491
🟢	Branches	93.44%	228/244
🟢	Functions	100%	136/136
🟢	Lines	99.15% (+0% 🔼)	467/471

Test suite run success

147 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from b93b2f6780b9c27b358898bee49a7e52ab9c4b2c

amtins commented 8 months ago

I've tested this on safari for iphone and mac and I've not observed any strange jumps. For me it's ok to enable this behaviour by default, the experience is much better specially for mobile devices.

@jboix thanks for the feedback, that's great!