feat(demo): use links instead of buttons

SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.

https://srgssr.github.io/pillarbox-web-demo/

MIT License

12 stars 1 forks source link

feat(demo): use links instead of buttons #158

Closed jboix closed 8 months ago

jboix commented 8 months ago

Description

Closes #149 Closes #150

This change refactors all the content buttons of the demo application into links enabling sharing and further navigation options.

Changes made

Created a ContentLinkComponent that implements a link within the application with the look of the previous buttons but replaces them for links.
Refactored all buttons on the "Examples," "Search," and "Lists" pages of the demo application to use the newly created component.
Corrected a regression introduced in the application's router regarding the base url.

github-actions[bot] commented 8 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	98.37%	483/491
🟢	Branches	93.44%	228/244
🟢	Functions	100%	136/136
🟢	Lines	99.15%	467/471

Test suite run success

147 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from f47c7ddfef84534af26205c1293d22b548876390

jboix commented 8 months ago

As discussed the intention was to style the slot as a "container" element. We've finally decided on using name as suggested here and introduced the styling through the pseudo element ::slotted as such :

::slotted([slot="description"]) {
  // style the element injected in the slot
}

This allows us to preserve a default style in the web component itself.