SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.
https://srgssr.github.io/pillarbox-web-demo/
MIT License
12 stars 1 forks source link

feat(demo): reorganize components and dialog refactor #161

Closed jboix closed 8 months ago

jboix commented 8 months ago

Description

Closes #152 Closes #153

This commit focuses on restructuring and enhancing the codebase for improved organization and maintainability. The key aspects of this commit include:

Changes made

1. Folder Layout Reorganization.

The demo folder now follows a revised layout structure:

This restructuring aims to make the demo page more intuitive and modular.

2. Refactor player-dialog to a web component

The player-dialog has been refactored into a web component. This refactor has led to a cleaner separation of concerns, isolating the dialog's styles from the main page.

3. Player Query Params Routing Logic

The logic responsible for handling the routing of player query parameters has been relocated to the player.js file. This ensures that the routing-related functionality is centralized within the appropriate file.

github-actions[bot] commented 8 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟢 Statements 98.39% 489/497
🟢 Branches 93.44% 228/244
🟢 Functions 100% 136/136
🟢 Lines 99.16% 473/477

Test suite run success

153 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 6085ab8650dac1e197f81412fc8756324d638e42