SRGSSR / pillarbox-web

Pillarbox is a versatile media playback ecosystem engineered for the web.
https://srgssr.github.io/pillarbox-web-demo/
MIT License
11 stars 1 forks source link

refactor(srgssr-middleware): move srgssr specific options declaration #209

Closed jboix closed 6 months ago

jboix commented 6 months ago

Description

Considering we generate two builds for the library it makes sense to perform the declaration of SRG SSR specific options in the middleware itself. This approach prevents the core build from exposing options specific to the SRG SSR business logic and ensures these options are only present when necessary.

Changes made

github-actions[bot] commented 6 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements 98.39% 490/498
🟒 Branches 93.44% 228/244
🟒 Functions 100% 135/135
🟒 Lines 99.16% 474/478

Test suite run success

152 tests passing in 9 suites.

Report generated by πŸ§ͺjest coverage report action from 773d1ee48c1ec80649f2fc2f5709522af71a5f06

amtins commented 6 months ago

@jboix While I agree that srgOptions should be moved as it only concerns SRG SSR, I believe that the trackers option should remain in pillarbox.

The original intention is to provide a placeholder for accessing the various trackers directly from the player. Even if the use of this placeholder is optional, its use case remains valid.

Would it be possible to change the commit header from refactor(middleware) to refactor(srgssr-middleware)?

jboix commented 6 months ago

As requested in: https://github.com/SRGSSR/pillarbox-web/pull/209#issuecomment-1953795954

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: