fix(srgssr-middleware): incompatibility of older browsers with nullish coalescing

SRGSSR / pillarbox-web

https://srgssr.github.io/pillarbox-web-demo/

MIT License

11 stars 1 forks source link

fix(srgssr-middleware): incompatibility of older browsers with nullish coalescing #229

Closed amtins closed 4 months ago

amtins commented 4 months ago

Description

The ?? operator has been removed, as it is not compatible with older browsers. This can be a problem when Pillarbox is used on televisions, for example.

Changes made

replace nullish coalescing by a ternary operator

github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-18 10:27 UTC

github-actions[bot] commented 4 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	98.81%	581/588
🟢	Branches	96%	288/300
🟢	Functions	99.4%	166/167
🟢	Lines	99.28%	552/556

Test suite run success

192 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 379b84b99e2a122ad906b63a3c5a93f4faf3ece7

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.4.3 :tada:

The release is available on:

npm package (@main dist-tag)
GitHub release

Your semantic-release bot :package::rocket: